From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH 4/5] hvmloader: add knob for fixed SMBIOS
 date string
Date: Mon, 23 Mar 2015 12:24:39 +0000
Message-ID: <55101417020000780006C8A5@mail.emea.novell.com>
References: <1426872279-5001-1-git-send-email-olaf@aepfle.de>
	<1426872279-5001-5-git-send-email-olaf@aepfle.de>
	<550FDEB2020000780006C785@mail.emea.novell.com>
	<20150323091506.GA17225@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150323091506.GA17225@aepfle.de>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 23.03.15 at 10:15, <olaf@aepfle.de> wrote:
> On Mon, Mar 23, Jan Beulich wrote:
> 
>> >>> On 20.03.15 at 18:24, <olaf@aepfle.de> wrote:
>> > To allow reproducible builds of hvmloader introduce a make variable
>> > SMBIOS_REL_DATE=mm/dd/yyyy to provide a fixed date string. Without this
>> > change the hvmloader binary changes with every rebuild.
>> 
>> I don't really object to this change, but didn't we discuss using
>> smbios.c's time stamp instead, which then would properly reflect
>> eventual changes during incremental builds along with producing
>> unchanged output when there hasn't been any change?
> 
> Using the file timestamp will actually break the attempt to get a
> reproducible build if the file is patched during package build.
> With each rebuild patch(1) will alter the timestamp.

Oh, right, so it's really the default we may want to alter. But that's
not subject of this patch then, so I'll go ack it.

Jan