From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbbCWQCT (ORCPT ); Mon, 23 Mar 2015 12:02:19 -0400 Received: from mail-am1on0069.outbound.protection.outlook.com ([157.56.112.69]:13248 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752508AbbCWQCR (ORCPT ); Mon, 23 Mar 2015 12:02:17 -0400 Message-ID: <551038FB.2070200@ezchip.com> Date: Mon, 23 Mar 2015 12:02:03 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Richard Cochran , CC: , Amir Vadai , "Ariel Elior" , Arnd Bergmann , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , "David Miller" , Frank Li , "Giuseppe Cavallaro" , Jeff Kirsher , John Stultz , "Luwei Zhou" , Matthew Vick , "Michael Chan" , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , =?windows-1252?Q?Stefan_S=F8rensen?= , Thomas Gleixner , Tom Lendacky Subject: Re: [PATCH net-next V2 19/23] ptp: tilegx: convert to the 64 bit get/set time methods. References: <8bc233b19d08308c01015936841d9be8d4441ece.1426973658.git.richardcochran@gmail.com> In-Reply-To: <8bc233b19d08308c01015936841d9be8d4441ece.1426973658.git.richardcochran@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN1PR12CA0007.namprd12.prod.outlook.com (25.160.77.17) To DB3PR02MB0538.eurprd02.prod.outlook.com (25.160.51.15) Authentication-Results: amd.com; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB0538;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB076; X-Microsoft-Antispam-PRVS: X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(6049001)(479174004)(24454002)(377454003)(51704005)(36756003)(92566002)(19580395003)(59896002)(19580405001)(66066001)(15975445007)(65956001)(2950100001)(77096005)(77156002)(47776003)(62966003)(65816999)(46102003)(76176999)(50986999)(50466002)(54356999)(33656002)(42186005)(40100003)(86362001)(83506001)(122386002)(87976001)(7059030)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR02MB0538;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010);SRVR:DB3PR02MB0538;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB0538; X-Forefront-PRVS: 05245CA661 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2015 16:02:10.4568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR02MB0538 X-OriginatorOrg: ezchip.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/21/2015 05:39 PM, Richard Cochran wrote: > This driver calls code (via gxio_mpipe_get/set_timestamp) that makes > the assumption that the tv_sec field is 64 bits wide. So apparently > this driver is 64 bit only. So maybe this driver and device are ready > for 2038, but maybe not. > > Not even compile tested. > > Signed-off-by: Richard Cochran This driver is 64-bit only. Would it make more sense to just change the accessors from gettime/settime to gettime/settime64 and nothing else, i.e. rely on the current behavior that timespec and timespec64 are the same type, and trust the compiler to fail it if somehow someone tried to build this driver into a 32-bit kernel? In any case, if you think it's better as-is, you can certainly have my Acked-by: Chris Metcalf -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Metcalf Subject: Re: [PATCH net-next V2 19/23] ptp: tilegx: convert to the 64 bit get/set time methods. Date: Mon, 23 Mar 2015 12:02:03 -0400 Message-ID: <551038FB.2070200@ezchip.com> References: <8bc233b19d08308c01015936841d9be8d4441ece.1426973658.git.richardcochran@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , Amir Vadai , "Ariel Elior" , Arnd Bergmann , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , "David Miller" , Frank Li , "Giuseppe Cavallaro" , Jeff Kirsher , John Stultz , "Luwei Zhou" , Matthew Vick , "Michael Chan" , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , =?windows-1252?Q?Stefan_S=F8rensen?= , Thoma To: Richard Cochran , Return-path: In-Reply-To: <8bc233b19d08308c01015936841d9be8d4441ece.1426973658.git.richardcochran@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 03/21/2015 05:39 PM, Richard Cochran wrote: > This driver calls code (via gxio_mpipe_get/set_timestamp) that makes > the assumption that the tv_sec field is 64 bits wide. So apparently > this driver is 64 bit only. So maybe this driver and device are ready > for 2038, but maybe not. > > Not even compile tested. > > Signed-off-by: Richard Cochran This driver is 64-bit only. Would it make more sense to just change the accessors from gettime/settime to gettime/settime64 and nothing else, i.e. rely on the current behavior that timespec and timespec64 are the same type, and trust the compiler to fail it if somehow someone tried to build this driver into a 32-bit kernel? In any case, if you think it's better as-is, you can certainly have my Acked-by: Chris Metcalf -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com