All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fan Du <fengyuleidian0615@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Erik Hugne <erik.hugne@ericsson.com>, netdev@vger.kernel.org
Subject: Re: tcp_v4_err/request sock refcnt leak?
Date: Tue, 24 Mar 2015 09:49:41 +0800	[thread overview]
Message-ID: <5510C2B5.2030609@gmail.com> (raw)
In-Reply-To: <1427119917.25985.66.camel@edumazet-glaptop2.roam.corp.google.com>

于 2015年03月23日 22:11, Eric Dumazet 写道:
>> I'm not familiar with this part, IMHO, this might be a double call for reqsk_put?
> It is yes.
>
> I got confused because reqsk_timer_handler()_has_  to call
> reqsk_put(req) after calling inet_csk_reqsk_queue_drop(), because
> the timer holds a reference on req.
>
> Would you like to send the official patch, mentioning :
>
> Fixes: fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")

Looks like I've over slept last night.
Thanks Eric for cooking the patch 8)

-- 
天下英雄出我辈，一入江湖岁月催。
鸿图霸业谈笑间，不胜人生一场醉。

  reply	other threads:[~2015-03-24  1:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23  9:03 tcp_v4_err/request sock refcnt leak? Erik Hugne
2015-03-23 10:27 ` Fan Du
2015-03-23 11:15   ` Erik Hugne
2015-03-23 14:11   ` Eric Dumazet
2015-03-24  1:49     ` Fan Du [this message]
2015-03-24  2:03       ` Eric Dumazet
2015-03-23 17:06   ` [PATCH net-next] inet: fix double request socket freeing Eric Dumazet
2015-03-23 21:01     ` David Miller
2015-03-23 22:00     ` [PATCH v2 " Eric Dumazet
2015-03-24  1:41       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5510C2B5.2030609@gmail.com \
    --to=fengyuleidian0615@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=erik.hugne@ericsson.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.