From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 2/2] x86/vMSI-X: add valid bits for read acceleration Date: Tue, 24 Mar 2015 07:49:53 +0000 Message-ID: <55112531020000780006CD4F@mail.emea.novell.com> References: <550C5065020000780006C27E@mail.emea.novell.com> <550C589D020000780006C2B2@mail.emea.novell.com> <20150323191146.GA20509@l.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YaJb1-0000dN-Q5 for xen-devel@lists.xenproject.org; Tue, 24 Mar 2015 07:49:55 +0000 In-Reply-To: <20150323191146.GA20509@l.oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Andrew Cooper , Keir Fraser , xen-devel List-Id: xen-devel@lists.xenproject.org >>> On 23.03.15 at 20:11, wrote: > On Fri, Mar 20, 2015 at 04:27:57PM +0000, Jan Beulich wrote: >> Again because Xen doesn't get to see all guest writes, it shouldn't >> serve reads from its cache before having seen a write to the respective >> address. >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Konrad Rzeszutek Wilk > >> >> --- a/xen/arch/x86/hvm/vmsi.c >> +++ b/xen/arch/x86/hvm/vmsi.c >> @@ -153,12 +153,15 @@ struct msixtbl_entry >> /* TODO: resolve the potential race by destruction of pdev */ >> struct pci_dev *pdev; >> unsigned long gtable; /* gpa of msix table */ >> - unsigned long table_flags[BITS_TO_LONGS(MAX_MSIX_TABLE_ENTRIES)]; >> + DECLARE_BITMAP(table_flags, MAX_MSIX_TABLE_ENTRIES); > > That seems unrelated to this patch? Perhaps mention the cleanup > part in the commit. Ah, yes, I meant to but forgot. Jan