From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86 Date: Tue, 24 Mar 2015 11:30:11 -0400 Message-ID: <55118303.8060003@oracle.com> References: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Will Deacon , Olof Johansson , Grant Likely Cc: Mark Rutland , Ashwin Chaugule , Lorenzo Pieralisi , Robert Richter , Arnd Bergmann , Graeme Gregory , linaro-acpi@lists.linaro.org, Marc Zyngier , Jon Masters , Timur Tabi , Mark Salter , linux-kernel@vger.kernel.org, Julien Grall , Konrad Rzeszutek Wilk , linux-acpi@vger.kernel.org, Mark Brown , David Vrabel , Suravee Suthikulpanit , Sudeep Holla , 'Stefano Stabellini' , linux-arm-kernel@lists.infradead.org List-Id: linux-acpi@vger.kernel.org On 03/24/2015 10:02 AM, Hanjun Guo wrote: > When ACPI is enabled on ARM64, XEN ACPI will also compiled > into the kernel, but XEN ACPI is x86 dependent, so introduce > CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is > functional on ARM64. > > CC: 'Stefano Stabellini' > CC: Julien Grall > CC: Konrad Rzeszutek Wilk > CC: Boris Ostrovsky > CC: David Vrabel > Signed-off-by: Hanjun Guo > --- > drivers/xen/Kconfig | 4 ++++ > drivers/xen/Makefile | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index b812462..a31cd29 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -253,4 +253,8 @@ config XEN_EFI > def_bool y > depends on X86_64 && EFI > > +config XEN_ACPI > + def_bool y > + depends on X86 && ACPI > + I think XEN_DOM0 (in arch/x86/xen/Kconfig) should select this option. Otherwise, if it is set to 'n', we won't be able to build enlighten.c (xen_start_kernel() -> xen_acpi_sleep_register() refers to xen_acpi_notify_hypervisor_sleep()). -boris > endmenu > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index 2ccd359..f4622ab 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -13,7 +13,7 @@ CFLAGS_efi.o += -fshort-wchar > > dom0-$(CONFIG_PCI) += pci.o > dom0-$(CONFIG_USB_SUPPORT) += dbgp.o > -dom0-$(CONFIG_ACPI) += acpi.o $(xen-pad-y) > +dom0-$(CONFIG_XEN_ACPI) += acpi.o $(xen-pad-y) > xen-pad-$(CONFIG_X86) += xen-acpi-pad.o > dom0-$(CONFIG_X86) += pcpu.o > obj-$(CONFIG_XEN_DOM0) += $(dom0-y) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbbCXPdF (ORCPT ); Tue, 24 Mar 2015 11:33:05 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25141 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbbCXPdA (ORCPT ); Tue, 24 Mar 2015 11:33:00 -0400 Message-ID: <55118303.8060003@oracle.com> Date: Tue, 24 Mar 2015 11:30:11 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Will Deacon , Olof Johansson , Grant Likely CC: Lorenzo Pieralisi , Arnd Bergmann , Mark Rutland , Graeme Gregory , Sudeep Holla , Jon Masters , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , Suravee Suthikulpanit , Mark Salter , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, "'Stefano Stabellini'" , Julien Grall , Konrad Rzeszutek Wilk , David Vrabel Subject: Re: [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86 References: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> In-Reply-To: <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/24/2015 10:02 AM, Hanjun Guo wrote: > When ACPI is enabled on ARM64, XEN ACPI will also compiled > into the kernel, but XEN ACPI is x86 dependent, so introduce > CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is > functional on ARM64. > > CC: 'Stefano Stabellini' > CC: Julien Grall > CC: Konrad Rzeszutek Wilk > CC: Boris Ostrovsky > CC: David Vrabel > Signed-off-by: Hanjun Guo > --- > drivers/xen/Kconfig | 4 ++++ > drivers/xen/Makefile | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index b812462..a31cd29 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -253,4 +253,8 @@ config XEN_EFI > def_bool y > depends on X86_64 && EFI > > +config XEN_ACPI > + def_bool y > + depends on X86 && ACPI > + I think XEN_DOM0 (in arch/x86/xen/Kconfig) should select this option. Otherwise, if it is set to 'n', we won't be able to build enlighten.c (xen_start_kernel() -> xen_acpi_sleep_register() refers to xen_acpi_notify_hypervisor_sleep()). -boris > endmenu > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index 2ccd359..f4622ab 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -13,7 +13,7 @@ CFLAGS_efi.o += -fshort-wchar > > dom0-$(CONFIG_PCI) += pci.o > dom0-$(CONFIG_USB_SUPPORT) += dbgp.o > -dom0-$(CONFIG_ACPI) += acpi.o $(xen-pad-y) > +dom0-$(CONFIG_XEN_ACPI) += acpi.o $(xen-pad-y) > xen-pad-$(CONFIG_X86) += xen-acpi-pad.o > dom0-$(CONFIG_X86) += pcpu.o > obj-$(CONFIG_XEN_DOM0) += $(dom0-y) From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.ostrovsky@oracle.com (Boris Ostrovsky) Date: Tue, 24 Mar 2015 11:30:11 -0400 Subject: [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86 In-Reply-To: <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> References: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> Message-ID: <55118303.8060003@oracle.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/24/2015 10:02 AM, Hanjun Guo wrote: > When ACPI is enabled on ARM64, XEN ACPI will also compiled > into the kernel, but XEN ACPI is x86 dependent, so introduce > CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is > functional on ARM64. > > CC: 'Stefano Stabellini' > CC: Julien Grall > CC: Konrad Rzeszutek Wilk > CC: Boris Ostrovsky > CC: David Vrabel > Signed-off-by: Hanjun Guo > --- > drivers/xen/Kconfig | 4 ++++ > drivers/xen/Makefile | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index b812462..a31cd29 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -253,4 +253,8 @@ config XEN_EFI > def_bool y > depends on X86_64 && EFI > > +config XEN_ACPI > + def_bool y > + depends on X86 && ACPI > + I think XEN_DOM0 (in arch/x86/xen/Kconfig) should select this option. Otherwise, if it is set to 'n', we won't be able to build enlighten.c (xen_start_kernel() -> xen_acpi_sleep_register() refers to xen_acpi_notify_hypervisor_sleep()). -boris > endmenu > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index 2ccd359..f4622ab 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -13,7 +13,7 @@ CFLAGS_efi.o += -fshort-wchar > > dom0-$(CONFIG_PCI) += pci.o > dom0-$(CONFIG_USB_SUPPORT) += dbgp.o > -dom0-$(CONFIG_ACPI) += acpi.o $(xen-pad-y) > +dom0-$(CONFIG_XEN_ACPI) += acpi.o $(xen-pad-y) > xen-pad-$(CONFIG_X86) += xen-acpi-pad.o > dom0-$(CONFIG_X86) += pcpu.o > obj-$(CONFIG_XEN_DOM0) += $(dom0-y)