All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: "Nicholas A. Bellinger" <nab@daterainc.com>,
	target-devel <target-devel@vger.kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	Sagi Grimberg <sagig@mellanox.com>,
	Slava Shwartsman <valyushash@gmail.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH 1/3] iscsi-target: Convert iscsi_thread_set usage to kthread.h
Date: Tue, 24 Mar 2015 18:37:52 +0200	[thread overview]
Message-ID: <551192E0.509@dev.mellanox.co.il> (raw)
In-Reply-To: <55100547.2090208@dev.mellanox.co.il>

On 3/23/2015 2:21 PM, Sagi Grimberg wrote:
> On 3/21/2015 8:16 AM, Nicholas A. Bellinger wrote:
>> From: Nicholas Bellinger <nab@linux-iscsi.org>
>>
>> This patch converts iscsi-target code to use modern kthread.h API
>> callers for creating RX/TX threads for each new iscsi_conn descriptor,
>> and releasing associated RX/TX threads during connection shutdown.
>>
>> This is done using iscsit_start_kthreads() -> kthread_run() to start
>> new kthreads from within iscsi_post_login_handler(), and invoking
>> kthread_stop() from existing iscsit_close_connection() code.
>>
>> Also, convert iscsit_logout_post_handler_closesession() code to use
>> cmpxchg when determing when iscsit_cause_connection_reinstatement()
>> needs to sleep waiting for completion.
>
> I'll run some tests with this.

Hi Nic,

I can report that this series (minus patch 3/3 and along with some
patches I'll send out soon) seems to resolve the list corruption issue
I've seen.

Overall the patches look good to me so feel free to include
patches 1+2 with:

Tested-by: Sagi Grimberg <sagig@mellanox.com>

Thanks!
Sagi.

  reply	other threads:[~2015-03-24 16:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21  6:16 [PATCH 0/3] iscsi/iser-target: Convert to kthread.h + fix logout failure Nicholas A. Bellinger
2015-03-21  6:16 ` [PATCH 1/3] iscsi-target: Convert iscsi_thread_set usage to kthread.h Nicholas A. Bellinger
2015-03-23 12:21   ` Sagi Grimberg
2015-03-24 16:37     ` Sagi Grimberg [this message]
2015-03-26  6:45       ` Nicholas A. Bellinger
2015-03-21  6:16 ` [PATCH 2/3] iscsi-target: Drop legacy iscsi_target_tq.c logic Nicholas A. Bellinger
2015-03-21  6:16 ` [PATCH 3/3] iser-target: Handle special case for logout during connection failure Nicholas A. Bellinger
2015-03-22 16:06   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551192E0.509@dev.mellanox.co.il \
    --to=sagig@dev.mellanox.co.il \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@daterainc.com \
    --cc=nab@linux-iscsi.org \
    --cc=sagig@mellanox.com \
    --cc=target-devel@vger.kernel.org \
    --cc=valyushash@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.