* [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig
@ 2015-03-24 5:33 Ray Jui
2015-03-25 0:28 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Ray Jui @ 2015-03-24 5:33 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Scott Branden, linux-pci, linux-kernel, bcm-kernel-feedback-list,
Ray Jui
Make PCIE_IPROC depending on both OF and ARM and default to be disabled,
so it cannot be accidentally enabled by other platforms
PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly
it's enabled by PCIE_IPROC_PLTFM driver
Signed-off-by: Ray Jui <rjui@broadcom.com>
---
drivers/pci/host/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index feccd0d..963b507 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -108,6 +108,8 @@ config PCI_VERSATILE
config PCIE_IPROC
tristate "Broadcom iProc PCIe controller"
+ depends on OF && ARM
+ default n
help
This enables the iProc PCIe core controller support for Broadcom's
iProc family of SoCs. An appropriate bus interface driver also needs
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig
2015-03-24 5:33 [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig Ray Jui
@ 2015-03-25 0:28 ` Bjorn Helgaas
2015-03-25 6:26 ` Ray Jui
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2015-03-25 0:28 UTC (permalink / raw)
To: Ray Jui; +Cc: Scott Branden, linux-pci, linux-kernel, bcm-kernel-feedback-list
On Tue, Mar 24, 2015 at 12:33 AM, Ray Jui <rjui@broadcom.com> wrote:
> Make PCIE_IPROC depending on both OF and ARM and default to be disabled,
> so it cannot be accidentally enabled by other platforms
>
> PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly
> it's enabled by PCIE_IPROC_PLTFM driver
>
> Signed-off-by: Ray Jui <rjui@broadcom.com>
> ---
> drivers/pci/host/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index feccd0d..963b507 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -108,6 +108,8 @@ config PCI_VERSATILE
>
> config PCIE_IPROC
> tristate "Broadcom iProc PCIe controller"
> + depends on OF && ARM
> + default n
> help
> This enables the iProc PCIe core controller support for Broadcom's
> iProc family of SoCs. An appropriate bus interface driver also needs
What pattern are you following? There must be other drivers with
similar front-end bus driver schemes, and I'd rather copy their
Kconfig descriptions than invent something new.
With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"? Doesn't
seem like there's anything to gain by abbreviating it.
Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig
2015-03-25 0:28 ` Bjorn Helgaas
@ 2015-03-25 6:26 ` Ray Jui
0 siblings, 0 replies; 3+ messages in thread
From: Ray Jui @ 2015-03-25 6:26 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Scott Branden, linux-pci, linux-kernel, bcm-kernel-feedback-list
Hi Bjorn,
On 3/24/2015 5:28 PM, Bjorn Helgaas wrote:
> On Tue, Mar 24, 2015 at 12:33 AM, Ray Jui <rjui@broadcom.com> wrote:
>> Make PCIE_IPROC depending on both OF and ARM and default to be disabled,
>> so it cannot be accidentally enabled by other platforms
>>
>> PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly
>> it's enabled by PCIE_IPROC_PLTFM driver
>>
>> Signed-off-by: Ray Jui <rjui@broadcom.com>
>>
>> drivers/pci/host/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>> index feccd0d..963b507 100644
>> --- a/drivers/pci/host/Kconfig
>> +++ b/drivers/pci/host/Kconfig
>> @@ -108,6 +108,8 @@ config PCI_VERSATILE
>>
>> config PCIE_IPROC
>> tristate "Broadcom iProc PCIe controller"
>> + depends on OF && ARM
>> + default n
>> help
>> This enables the iProc PCIe core controller support for Broadcom's
>> iProc family of SoCs. An appropriate bus interface driver also needs
>
> What pattern are you following? There must be other drivers with
> similar front-end bus driver schemes, and I'd rather copy their
> Kconfig descriptions than invent something new.
I'm not aware of other drivers using a similar model to support
different front-end bus interfaces. Note this is requested by Arnd
Bergmann to support a normal platform bus interface and a BCMA bus
interface, which is quite unique.
PCIE_DW may be close in a way in terms of how the core code are retained
in PCIE_DW driver with PCI_EXYNOS, PCI_IMX6, and etc. to take care of
SoC specific things.
Note PCIE_DW currently has no Kconfig descriptions.
>
> With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"? Doesn't
> seem like there's anything to gain by abbreviating it.
Sure. I'll submit a new patch series, which will contain this patch, and
another patch on top, to change from CONFIG_PCIE_IPROC_PLTFM to
CONFIG_PCIE_IPROC_PLATFORM.
>
> Bjorn
>
Thanks,
Ray
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-25 6:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-24 5:33 [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig Ray Jui
2015-03-25 0:28 ` Bjorn Helgaas
2015-03-25 6:26 ` Ray Jui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.