All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Alrae <leon.alrae@imgtec.com>
To: "Andreas Färber" <afaerber@suse.de>,
	"Dirk Müller" <dirk@dmllr.de>,
	qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Cc: "Stefan Weil" <sw@weilnetz.de>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory
Date: Wed, 25 Mar 2015 13:23:15 +0000	[thread overview]
Message-ID: <5512B6C3.2060005@imgtec.com> (raw)
In-Reply-To: <5511ECD4.1030507@suse.de>

On 24/03/2015 23:01, Andreas Färber wrote:
> Am 24.03.2015 um 22:28 schrieb Dirk Müller:
>> Commit 0b183fc871:"memory: move mem_path handling to
>> memory_region_allocate_system_memory" split memory_region_init_ram and
>> memory_region_init_ram_from_file. Also it moved mem-path handling a step
>> up from memory_region_init_ram to memory_region_allocate_system_memory.
>>
>> Therefore for any board that uses memory_region_init_ram directly,
>> -mem-path is not supported.
>>
>> Fix this by replacing memory_region_init_ram with
>> memory_region_allocate_system_memory.
>>
>> Signed-off-by: Dirk Mueller <dmueller@suse.com>
>> ---
>>  hw/mips/mips_fulong2e.c | 3 +--
>>  hw/mips/mips_jazz.c     | 5 ++---
>>  hw/mips/mips_malta.c    | 5 ++---
>>  hw/mips/mips_mipssim.c  | 5 ++---
>>  hw/mips/mips_r4k.c      | 3 +--
>>  5 files changed, 8 insertions(+), 13 deletions(-)
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Leon and Paolo, I assume one of you will be handling this?
> 

Acked-by: Leon Alrae <leon.alrae@imgtec.com>

Paolo, is this going via your memory API pullreq?

Regards,
Leon

  reply	other threads:[~2015-03-25 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 21:28 [Qemu-devel] [PATCH for-2.3] mips: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory Dirk Müller
2015-03-24 23:01 ` Andreas Färber
2015-03-25 13:23   ` Leon Alrae [this message]
2015-03-25 13:32     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5512B6C3.2060005@imgtec.com \
    --to=leon.alrae@imgtec.com \
    --cc=afaerber@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=dirk@dmllr.de \
    --cc=hpoussin@reactos.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.