All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <david.ahern@oracle.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH] perf record: Allow poll timeout to be specified
Date: Wed, 25 Mar 2015 08:37:21 -0600	[thread overview]
Message-ID: <5512C821.7020600@oracle.com> (raw)
In-Reply-To: <20150325123855.GC26966@krava.brq.redhat.com>

On 3/25/15 6:38 AM, Jiri Olsa wrote:
> On Tue, Mar 24, 2015 at 12:09:48PM -0400, David Ahern wrote:
>> Record currently wakes up based on watermarks to read events from the mmaps and
>> write them out to the file. The result is a file that can have large blocks of
>> events per mmap before a finished round event is added to the stream.  This in
>> turn affects the quantity of events that have to be passed through the ordered
>> events queue before results can be displayed to the user. For commands like
>> perf-script this can lead to long unnecessarily long delays before a user gets
>> output. Large systems (e.g, 1024 cpus) further compound this effect. I have seen
>> instances where I have to wait 45 minutes for perf-script to process a 5GB file
>> before any events are shown.
>
> so you have pipe to perf script, right?

$ perf record ....
$ perf script ...
<wait an eternity>
data

>
>>
>> This patch adds an option to perf-record to allow a user to specify the
>> poll timeout in msec. For example using 100 msec timeouts similar to perf-top
>> means the mmaps are traversed much more frequently leading to a smoother
>> analysis side.
>
> there's also the '--no-buffering' option that sets:
>
>                  attr->watermark = 0;
>                  attr->wakeup_events = 1;
>
> but that's just the other edge, which is not what you'd want

right, that is the other extreme. record would never go to sleep.

>
> I think it's good to have user side configurable as well
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> thanks,
> jirka
>


      reply	other threads:[~2015-03-25 14:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 16:09 [PATCH] perf record: Allow poll timeout to be specified David Ahern
2015-03-24 16:12 ` Ingo Molnar
2015-03-24 16:18   ` David Ahern
2015-03-24 21:21   ` Arnaldo Carvalho de Melo
2015-03-25  9:11     ` Ingo Molnar
2015-03-25 12:14       ` Arnaldo Carvalho de Melo
2015-03-25 14:41         ` David Ahern
2015-03-25 18:20           ` Ingo Molnar
2015-03-25 12:38 ` Jiri Olsa
2015-03-25 14:37   ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5512C821.7020600@oracle.com \
    --to=david.ahern@oracle.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.