From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FE35C6FD19 for ; Mon, 13 Mar 2023 17:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1BAzLBrigpLegeVpIwXy3pO1DfJiZXd9exraC7aCQS0=; b=CA1xkroabP9R/Y 1rHi2RulL0bnVTd0hU48Liajvw4kBqLJqh6zWt3KxKfO/vrDTBtwgPGqzLd8gce5O4Iunr8bfP2mR C+cSx1zk6bPp/UBhyx7nQ+uxDivuDeGlIXB2m0gIwHc5rbof0nCp444yt+IwHKqNqXKiaYdZ4yNoF JZCg39b8jv4GTm0/XAJKdW0MvidFR9MYATtHbDYYNHO4kmgz0pe01M6uO42iwUNVX0i8rkrwQ5ixy XX4/T0f7B45aheh7ZQlMV7QPbnHi03TsuhBVFLoyUsyol9G0EnsKHU8JJ320FPgALIOr5YNmThF9V mSiBH9ktZHn5wpSw9PDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbm6G-007A2D-UE; Mon, 13 Mar 2023 17:36:45 +0000 Received: from www381.your-server.de ([78.46.137.84]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbm67-0079yt-PG for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 17:36:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=Lt4mtIjD4YyqKIuyjla1T3Ra1U7Xq48NvAy7VCekmRA=; b=g0r/lWXHFdizF5Hl/TIfhR8fWF NMwSnoXGienHTsvDiDVVuUhUdbZageGCHqFcSPB62BhE+aE1EvX/pM6fSD7mVorRljtom07PFW9uf 4wsKDq0kUP1aIx7PLLAaovyhBZunUsJwoiOUWB4q93uZkwxhXPK/P26a8hR9PZl3O5cRboFtObBOB sHwG5eWy6VGSqHyoYAebRR3131LkIKuj9dXMEuat/buc2XmCp40Kn/rxfaysd6SB9FG5EqD856mJe X1/FF8EULD1S8990dV0hl5uqGdSkv5f7+U7fEaD0Dp1RgXIoB6xsxBpkIuN9iDtDCfFzhl9ck9ebN 4QxuIUAw==; Received: from sslproxy01.your-server.de ([78.46.139.224]) by www381.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pbm5w-000O5g-P4; Mon, 13 Mar 2023 18:36:24 +0100 Received: from [2604:5500:c0e5:eb00:da5e:d3ff:feff:933b] by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbm5w-000XJa-7C; Mon, 13 Mar 2023 18:36:24 +0100 Message-ID: <5513e68a-22b8-2c91-5342-b1796741610d@metafoo.de> Date: Mon, 13 Mar 2023 10:36:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/5] dmaengine: axi-dmac: Don't set chancnt Content-Language: en-US To: Jisheng Zhang , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20230313170250.815-1-jszhang@kernel.org> <20230313170250.815-3-jszhang@kernel.org> From: Lars-Peter Clausen In-Reply-To: <20230313170250.815-3-jszhang@kernel.org> X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.103.8/26840/Mon Mar 13 08:22:58 2023) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_103635_877265_DC3D65B2 X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/13/23 10:02, Jisheng Zhang wrote: > The dma framework will calculate the dma channels chancnt, setting it > outself is wrong. s/outself/ourself/ Looks good otherwise, thanks. Acked-by: Lars-Peter Clausen > > Signed-off-by: Jisheng Zhang > --- > drivers/dma/dma-axi-dmac.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c > index a812b9b00e6b..fc7cdad37161 100644 > --- a/drivers/dma/dma-axi-dmac.c > +++ b/drivers/dma/dma-axi-dmac.c > @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev) > dma_dev->device_terminate_all = axi_dmac_terminate_all; > dma_dev->device_synchronize = axi_dmac_synchronize; > dma_dev->dev = &pdev->dev; > - dma_dev->chancnt = 1; > dma_dev->src_addr_widths = BIT(dmac->chan.src_width); > dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); > dma_dev->directions = BIT(dmac->chan.direction); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAD3C61DA4 for ; Mon, 13 Mar 2023 17:59:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbjCMR7Q (ORCPT ); Mon, 13 Mar 2023 13:59:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjCMR7Q (ORCPT ); Mon, 13 Mar 2023 13:59:16 -0400 X-Greylist: delayed 1365 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 13 Mar 2023 10:59:14 PDT Received: from www381.your-server.de (www381.your-server.de [78.46.137.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 746A84FF27; Mon, 13 Mar 2023 10:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=Lt4mtIjD4YyqKIuyjla1T3Ra1U7Xq48NvAy7VCekmRA=; b=g0r/lWXHFdizF5Hl/TIfhR8fWF NMwSnoXGienHTsvDiDVVuUhUdbZageGCHqFcSPB62BhE+aE1EvX/pM6fSD7mVorRljtom07PFW9uf 4wsKDq0kUP1aIx7PLLAaovyhBZunUsJwoiOUWB4q93uZkwxhXPK/P26a8hR9PZl3O5cRboFtObBOB sHwG5eWy6VGSqHyoYAebRR3131LkIKuj9dXMEuat/buc2XmCp40Kn/rxfaysd6SB9FG5EqD856mJe X1/FF8EULD1S8990dV0hl5uqGdSkv5f7+U7fEaD0Dp1RgXIoB6xsxBpkIuN9iDtDCfFzhl9ck9ebN 4QxuIUAw==; Received: from sslproxy01.your-server.de ([78.46.139.224]) by www381.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pbm5w-000O5g-P4; Mon, 13 Mar 2023 18:36:24 +0100 Received: from [2604:5500:c0e5:eb00:da5e:d3ff:feff:933b] by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbm5w-000XJa-7C; Mon, 13 Mar 2023 18:36:24 +0100 Message-ID: <5513e68a-22b8-2c91-5342-b1796741610d@metafoo.de> Date: Mon, 13 Mar 2023 10:36:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/5] dmaengine: axi-dmac: Don't set chancnt Content-Language: en-US To: Jisheng Zhang , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20230313170250.815-1-jszhang@kernel.org> <20230313170250.815-3-jszhang@kernel.org> From: Lars-Peter Clausen In-Reply-To: <20230313170250.815-3-jszhang@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.103.8/26840/Mon Mar 13 08:22:58 2023) Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 3/13/23 10:02, Jisheng Zhang wrote: > The dma framework will calculate the dma channels chancnt, setting it > outself is wrong. s/outself/ourself/ Looks good otherwise, thanks. Acked-by: Lars-Peter Clausen > > Signed-off-by: Jisheng Zhang > --- > drivers/dma/dma-axi-dmac.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c > index a812b9b00e6b..fc7cdad37161 100644 > --- a/drivers/dma/dma-axi-dmac.c > +++ b/drivers/dma/dma-axi-dmac.c > @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev) > dma_dev->device_terminate_all = axi_dmac_terminate_all; > dma_dev->device_synchronize = axi_dmac_synchronize; > dma_dev->dev = &pdev->dev; > - dma_dev->chancnt = 1; > dma_dev->src_addr_widths = BIT(dmac->chan.src_width); > dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); > dma_dev->directions = BIT(dmac->chan.direction);