* [PATCH - nfs-utils] mount: improve error message when statd cannot be started.
@ 2015-03-23 5:44 NeilBrown
2015-03-26 15:30 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: NeilBrown @ 2015-03-23 5:44 UTC (permalink / raw)
To: Steve Dickson, NFS
[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]
If you try to mount and NFSv3 filesystem, and statd is not running
and cannot be started (maybe rpcbind isn't running either), the
error message is:
mount.nfs: rpc.statd is not running but is required for remote locking.
mount.nfs: Either use '-o nolock' to keep locks local, or start statd.
mount.nfs: an incorrect mount option was specified
That last line is incorrect and misleading: no incorret mount option was
specified.
This line comes from mount_error() in error.c. In this case that
function doesn't really need to provide any more information.
So introduce a concention that EALREADY means an error message has
already been printed, and use it to suppress that message.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/utils/mount/error.c b/utils/mount/error.c
index e06f598e96e3..c9797fc380c4 100644
--- a/utils/mount/error.c
+++ b/utils/mount/error.c
@@ -247,6 +247,9 @@ void mount_error(const char *spec, const char *mount_point, int error)
nfs_error(_("%s: please report the error to" PACKAGE_BUGREPORT),
progname);
break;
+ case EALREADY:
+ /* Error message has already been provided */
+ break;
default:
nfs_error(_("%s: %s"),
progname, strerror(error));
diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index 76ecb3292860..df67facdd9d1 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -298,6 +298,7 @@ static int nfs_verify_lock_option(struct mount_options *options)
"required for remote locking."), progname);
nfs_error(_("%s: Either use '-o nolock' to keep "
"locks local, or start statd."), progname);
+ errno = EALREADY; /* Don't print further error message */
return 0;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH - nfs-utils] mount: improve error message when statd cannot be started.
2015-03-23 5:44 [PATCH - nfs-utils] mount: improve error message when statd cannot be started NeilBrown
@ 2015-03-26 15:30 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2015-03-26 15:30 UTC (permalink / raw)
To: NeilBrown, NFS
On 03/23/2015 01:44 AM, NeilBrown wrote:
>
>
> If you try to mount and NFSv3 filesystem, and statd is not running
> and cannot be started (maybe rpcbind isn't running either), the
> error message is:
>
> mount.nfs: rpc.statd is not running but is required for remote locking.
> mount.nfs: Either use '-o nolock' to keep locks local, or start statd.
> mount.nfs: an incorrect mount option was specified
>
> That last line is incorrect and misleading: no incorret mount option was
> specified.
>
> This line comes from mount_error() in error.c. In this case that
> function doesn't really need to provide any more information.
>
> So introduce a concention that EALREADY means an error message has
> already been printed, and use it to suppress that message.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Committed...
steved.
>
> diff --git a/utils/mount/error.c b/utils/mount/error.c
> index e06f598e96e3..c9797fc380c4 100644
> --- a/utils/mount/error.c
> +++ b/utils/mount/error.c
> @@ -247,6 +247,9 @@ void mount_error(const char *spec, const char *mount_point, int error)
> nfs_error(_("%s: please report the error to" PACKAGE_BUGREPORT),
> progname);
> break;
> + case EALREADY:
> + /* Error message has already been provided */
> + break;
> default:
> nfs_error(_("%s: %s"),
> progname, strerror(error));
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 76ecb3292860..df67facdd9d1 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -298,6 +298,7 @@ static int nfs_verify_lock_option(struct mount_options *options)
> "required for remote locking."), progname);
> nfs_error(_("%s: Either use '-o nolock' to keep "
> "locks local, or start statd."), progname);
> + errno = EALREADY; /* Don't print further error message */
> return 0;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-26 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 5:44 [PATCH - nfs-utils] mount: improve error message when statd cannot be started NeilBrown
2015-03-26 15:30 ` Steve Dickson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.