From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbD2w-0007D0-Cs for qemu-devel@nongnu.org; Thu, 26 Mar 2015 15:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbD2s-0001XT-DO for qemu-devel@nongnu.org; Thu, 26 Mar 2015 15:02:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbD2s-0001XF-6B for qemu-devel@nongnu.org; Thu, 26 Mar 2015 15:02:22 -0400 Message-ID: <551457B8.30005@redhat.com> Date: Thu, 26 Mar 2015 13:02:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-14-git-send-email-eblake@redhat.com> <87sicrzrau.fsf@blackfin.pond.sub.org> In-Reply-To: <87sicrzrau.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C925tC81Pq5bMgKC5bWuKrqj5kvUPs4h2" Subject: Re: [Qemu-devel] [PATCH v5 13/28] qapi: Add some expr tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C925tC81Pq5bMgKC5bWuKrqj5kvUPs4h2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/26/2015 09:55 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Demonstrate that the qapi generator doesn't deal well with >> expressions that aren't up to par. Later patches will improve >> the expected results as the generator is made stricter. Only >> one of the added tests actually behaves sanely at rejecting >> obvious problems. >> >=20 > qapi-code-gen.txt documents the naming conventions: >=20 > Types, commands, and events share a common namespace. Therefore, > generally speaking, type definitions should always use CamelCase fo= r > user-defined type names, while built-in types are lowercase. Type > definitions should not end in 'Kind', as this namespace is used for= > creating implicit C enums for visiting union types. Command names,= > and field names within a type, should be all lower case with words > separated by a hyphen. However, some existing older commands and > complex types use underscore; when extending such expressions, > consistency is preferred over blindly avoiding underscore. Event > names should be ALL_CAPS with words separated by underscore. The > special string '**' appears for some commands that manually perform= > their own type checking rather than relying on the type-safe code > produced by the qapi code generators. >=20 > We should either enforce the conventions consistently, or not at all. >=20 > Enforcing them makes certain kinds of name clashes in generated C > impossible. If we don't enforce them, we should catch the clashes. >=20 > Since I haven't read to the end of your series, I have to ask: do you > intend to enforce them? I added tests to enforce it for event names, but did not enforce things for command names or complex type members. I guess that can be added on top, if desired. So, did this patch get R-b? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --C925tC81Pq5bMgKC5bWuKrqj5kvUPs4h2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVFFe4AAoJEKeha0olJ0Nq9HIH+wZWtQIKzi3zPg6/bdtTiAUI psvmj4bjO0JMsgUGfwybzRjdeU99N7j++RyWt/2Qc4qseHuoMQKTqsyT3OdBjfAw JDwLgIV4N1esqHamxUWrlvZ6eLMlCKuprAUj7KzaFIYm3Z49m0O2yYqXZx+BhDIb kpkZyOyU7sSeTGDU3Z1fd2jIQjaWk1LGw7V+qb5kpXhtc6AtqY7vPJB0hxPNRgYM 8KQ2MPd2bZkEhR6vLWRia12JFo4sMhsEs+7rgnsT0dhjiafLG8pBXR5uVZrGjAZY HIQkf4I+FKBeKeojUZfQZwaI9cWhpA7M5y4I350+fpxgUENFWLJ6D/d1BXWCAos= =s6+r -----END PGP SIGNATURE----- --C925tC81Pq5bMgKC5bWuKrqj5kvUPs4h2--