From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbD5s-0000Fk-0z for qemu-devel@nongnu.org; Thu, 26 Mar 2015 15:05:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbD5o-00031X-NR for qemu-devel@nongnu.org; Thu, 26 Mar 2015 15:05:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbD5o-00031S-Fi for qemu-devel@nongnu.org; Thu, 26 Mar 2015 15:05:24 -0400 Message-ID: <55145872.6070005@redhat.com> Date: Thu, 26 Mar 2015 13:05:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-19-git-send-email-eblake@redhat.com> <87wq23wte4.fsf@blackfin.pond.sub.org> In-Reply-To: <87wq23wte4.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JWAE52fOcA7NHRebUvopFf38dnRMmn8Hi" Subject: Re: [Qemu-devel] [PATCH v5 18/28] qapi: Unify type bypass and add tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JWAE52fOcA7NHRebUvopFf38dnRMmn8Hi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/26/2015 11:38 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> For a few QMP commands, we are forced to pass an arbitrary type >> without tracking it properly in QAPI. Among the existing clients, >> this unnamed type was spelled 'dict', 'visitor', and '**'; this >> patch standardizes on '**'. >> >> Meanwhile, for both 'gen' and 'success-response' keys, we have been >> ignoring the value, although the schema consistently used "'no'". >> But now that we can support a literal "false" in the schema, we >> might as well use that rather than ignoring the value or >> special-casing a random string. >> >> There is no difference to the generated code. As these features >> were previously undocumented before this series, add some tests >> and documentation on what we'd like to guarantee, although it will >> take later patches to clean up test results and actually enforce >> the use of a bool parameter. >=20 > You don't actually add documentation in this patch. Hmm, more evidence that I waffled about per-commit doc fixes, vs. lumping it all in patch 1, and I obviously failed to scrub the commit messages after changing my mind. >=20 > Aside: 'gen': false is required when '**' is used anywhere in the > command. If it was permitted only then, it would be redundant. I thin= k > we happily accept 'gen': false without '**' so far, although we don't > use it. That's okay. Also, even though the code accepts 'gen':false, it rejects 'gen':true ('gen' is only a one-way switch away from the default). Also something I didn't think worth worrying about. >=20 >> Signed-off-by: Eric Blake >=20 > Reviewed-by: Markus Armbruster >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JWAE52fOcA7NHRebUvopFf38dnRMmn8Hi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVFFhyAAoJEKeha0olJ0NqHGQH/A5zWFCsZVacKkw1r5WkgoDW aAA9mp8/xwteWp2DOldIsim0+toDDTe00R0haETIzgNvLx74F7aCpKTJ19gk59ow yNMRYdwSx84KJ+SrFtSvYpIZRR6KmpKIM/ghKeCqRQOaJ4qr0ExvJTdNTeO+N4Ai XEQTTo5lYYe8VW9A6NXKdBsHsnNjd0GoVPw8caBQh4QtGS+NLLTnZ+rvUNmEm3jp arZ6QAG3Lr/gQpJnBgIFpxtB0dcwQd4Oso65vXlzlibVtDHrQyHxKKXHp/JnQ68b yhdn0Vy63KqOufQPEiNB/sVpoXqfPiV7xLKQVCqFNzUvVvZsCWAhOO55QXw6f9I= =Fj6C -----END PGP SIGNATURE----- --JWAE52fOcA7NHRebUvopFf38dnRMmn8Hi--