All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Peter Hurley <peter@hurleysoftware.com>
Cc: Imre Deak <imre.deak@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order
Date: Thu, 26 Mar 2015 12:59:05 -0700	[thread overview]
Message-ID: <55146509.4020809@virtuousgeek.org> (raw)
In-Reply-To: <CAKMK7uHfimdJVTfueHkCO61b_+rwcEPo90FxZodEMpSX-B6sLw@mail.gmail.com>

On 12/16/2014 09:42 AM, Daniel Vetter wrote:
> On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley <peter@hurleysoftware.com> wrote:
>> On 12/16/2014 11:22 AM, Imre Deak wrote:
>>> On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote:
>>>> Fine. Just another expedient fix piled on top of other expedient fixes
>>>> that go back past 3.9 with no end in sight.
>>>
>>> I'm also happy to look into narrowing down the scope of console_lock in
>>> fbdev/fbcon as was suggested. But doing that as a follow-up to this
>>> change still makes sense to me since it will take more time and have the
>>> risk of regressions that are not related to what this change fixes.
>>
>> I apologize for my tone. I'm not blaming you for the current situation,
>> nor is it your responsibility to go fix vt/fbcon/fbdev driver stack
>> inversion. I'm just trying to bring some awareness of the larger scope,
>> so that collectively we take action and resolve the underlying problems.
> 
> Yeah I guess I should tune down my NACK to a Grumpy-if-merged-by too.
> We have a lot of nonoptimal solutions at hand here :(

So where does that leave us with this fix?  Should we wait for someone
to come along and do all the rework?  Imre said he'd be willing to do
it, but still feels this fix makes sense.

Or we could just abandon the fb layer altogether (my preference).  In
that case fixing this is fine, since we'll be able to ignore it for
configs that switch over to using !fbdev and kmscon.

Thanks,
Jesse


  reply	other threads:[~2015-03-26 19:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15 22:15 [PATCH v4 1/3] vt: fix check for system/busy console drivers when unregistering them Imre Deak
2014-12-15 22:16 ` [PATCH v4 2/3] vt: fix locking around vt_bind/vt_unbind Imre Deak
2014-12-16  7:37   ` Daniel Vetter
2014-12-15 22:16 ` [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order Imre Deak
2014-12-16  7:53   ` Daniel Vetter
2014-12-16 10:23     ` Imre Deak
2014-12-16 12:50       ` Peter Hurley
2014-12-16 13:45         ` Daniel Vetter
2014-12-16 14:38         ` Imre Deak
2014-12-16 15:00           ` Peter Hurley
2014-12-16 15:10             ` Daniel Vetter
2014-12-16 15:48               ` Peter Hurley
2014-12-16 16:22             ` Imre Deak
2014-12-16 17:15               ` Peter Hurley
2014-12-16 17:42                 ` Daniel Vetter
2015-03-26 19:59                   ` Jesse Barnes [this message]
2015-03-26 21:01                     ` Greg Kroah-Hartman
2015-03-26 21:05                       ` Imre Deak
2015-03-27  7:46                         ` Daniel Vetter
2015-03-31 15:59                           ` Greg Kroah-Hartman
2015-04-01 18:06                             ` [PATCH] " Imre Deak
2014-12-16  7:35 ` [PATCH v4 1/3] vt: fix check for system/busy console drivers when unregistering them Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55146509.4020809@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=imre.deak@intel.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.