From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:47663 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbbCZUih (ORCPT ); Thu, 26 Mar 2015 16:38:37 -0400 Message-ID: <55146E4C.508@redhat.com> Date: Thu, 26 Mar 2015 15:38:36 -0500 From: Eric Sandeen MIME-Version: 1.0 To: fdmanana@gmail.com CC: Chris Mason , linux-btrfs Subject: Re: I think "btrfs: fix leak of path in btrfs_find_item" broke stable trees ... References: <55137BE2.80603@redhat.com> <5514137E.6080804@redhat.com> <1427381284.28930.5@mail.thefacebook.com> <55143DD7.2020608@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 3/26/15 12:25 PM, Filipe David Manana wrote: > On Thu, Mar 26, 2015 at 5:11 PM, Eric Sandeen wrote: >> On 3/26/15 9:48 AM, Chris Mason wrote: >>> On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen wrote: >> >> ... >> >>>>>> 9c4f61f btrfs: simplify insert_orphan_item >>>>>> >>>>>> made the whole path alloc/free go away. >>>> >>>> so I think there's no need for my patch; may as well just send the above to stable >>>> and fix it that way, as long as 9c4f61f is deemed safe & correct, I think. >>> >>> Nice catch, thanks Eric. 9c4f61f looks fine for stable to me, but >>> since he's already testing on stable, I talked Eric into giving it a >>> pass through xfstests before I send it up. >>> >>> -chris >> >> ./check -g auto on 3.19-stable-ish seems fine-ish. Certainly no worse w/ the patch added :) >> >> Failures: btrfs/010 btrfs/017 btrfs/078 generic/015 generic/039 generic/040 generic/041 generic/065 generic/066 generic/071 generic/204 >> Failed 11 of 202 tests > > Just curious, how did btrfs/078 fail? It isn't supposed to fail on > 3.19.x nor 3.18.x. This was the use after free / segfault / valgrind splat from userspace that I reported yesterday. btrfs/078 104s ... 106s *** glibc detected *** btrfs check: double free or corruption (fasttop): 0x0000000000c12a40 *** ... ./common/rc: line 1932: 43334 Aborted btrfsck $device > $tmp.fsck 2>&1 _check_btrfs_filesystem: filesystem on /dev/sdc5 is inconsistent (see /mnt/test2/git/xfstests/results//btrfs/078.full) Ran: btrfs/078 Failures: btrfs/078 Failed 1 of 1 tests -Eric