From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753535AbbCZXtX (ORCPT ); Thu, 26 Mar 2015 19:49:23 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:47986 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429AbbCZXtT (ORCPT ); Thu, 26 Mar 2015 19:49:19 -0400 X-AuditID: cbfee68e-f79b46d000002b74-a5-55149afcb20c Message-id: <55149AFC.1080009@samsung.com> Date: Fri, 27 Mar 2015 08:49:16 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Lee Jones Cc: Krzysztof Kozlowski , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver References: <1425291038-18269-3-git-send-email-jaewon02.kim@samsung.com> <20150307201340.GF5233@earth> <54FCEABE.9000007@samsung.com> <54FD880E.30903@samsung.com> <1425903199.13415.9.camel@AMDC1943> <54FEF541.6000305@samsung.com> <551119DE.2070402@samsung.com> <551408E0.3060901@samsung.com> <20150326135412.GJ5951@x1> In-reply-to: <20150326135412.GJ5951@x1> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsWyRsSkRPfPLJFQg6O79S2uf3nOajH/yDlW i8OLXjBa9L9ZyGpx7tVKRotJ9yewWOxoOMJq8fqFocX9r0cZLW5++sZqcXnXHDaLz71HGC2W Xr/IZDFh+loWi9a9R9gtjn86yGJxeneJg6DHmnlrGD0u9/UyeeycdZfdY+XyL2wem1Z1snnc ubaHzaNvyypGj8+b5AI4orhsUlJzMstSi/TtErgypv85x14wX61iwZoHrA2Mx+W7GDk4JARM JCY/Ke9i5AQyxSQu3FvPBmILCSxllLh3iw8ibiLR9GgVcxcjF1B8OqPE0R1PmSCcB4wSM89s YQap4hXQkrh7/zUjiM0ioCpxdkYTE4jNJqAp8X7KFRaQZaICERK3L3NClAtK/Jh8DywsIqAi ce6NOchIZoGrLBKrNnwGO0JYIFJi4rbrUAddYZaYNYMfxOYUUJfobARZxQHUoC4xZUouSJhZ QF5i85q3zBA3r+WQmH+QC+IaAYlvkw+xQLwrK7HpAFSJpMTBFTdYJjCKzUJy0CyEobOQDF3A yLyKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIzDWT/971reD8eYB60OMAhyMSjy8P/qFQ4VY E8uKK3MPMZoCHTGRWUo0OR+YUPJK4g2NzYwsTE1MjY3MLc2UxHkTpH4GCwmkJ5akZqemFqQW xReV5qQWH2Jk4uCUamBU7Vhy7Mnu5ZMOH74btGlXSU/fnhlf7A5N6My+cUnCzIn9ud+7MJdn Xd/rr1/NClFZM2Wn3kxlnqLG4pbPdd8kQ3/dM05i2L8oWEY6zC1eUO+riI3EI96M54zB9gVG q1Mj3O5rnxc+3dQc3XeuLjWhZs8+L5mpT+c6zvPoEFTZ19N8MM7v2w8lluKMREMt5qLiRADH MbGb8AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsVy+t9jQd0/s0RCDf7OUrG4/uU5q8X8I+dY LQ4vesFo0f9mIavFuVcrGS0m3Z/AYrGj4QirxesXhhb3vx5ltLj56RurxeVdc9gsPvceYbRY ev0ik8WE6WtZLFr3HmG3OP7pIIvF6d0lDoIea+atYfS43NfL5LFz1l12j5XLv7B5bFrVyeZx 59oeNo++LasYPT5vkgvgiGpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshL zE21VXLxCdB1y8wBekNJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmDH9 zzn2gvlqFQvWPGBtYDwu38XIySEhYCLR9GgVM4QtJnHh3nq2LkYuDiGB6YwSR3c8ZYJwHjBK zDyzBayKV0BL4u7914wgNouAqsTZGU1MIDabgKbE+ylXWLoYOThEBSIkbl/mhCgXlPgx+R5Y WERAReLcG3OQkcwCV1kkVm34zAZSIywQKTFx23UwW0jgCrPErBn8IDangLpEZyPIKg6gBnWJ KVNyQcLMAvISm9e8ZZ7AKDALyYZZCFWzkFQtYGRexSiaWpBcUJyUnmukV5yYW1yal66XnJ+7 iRGcTp5J72Bc1WBxiFGAg1GJh/dHv3CoEGtiWXFl7iFGCQ5mJRHeSVNEQoV4UxIrq1KL8uOL SnNSiw8xmgK9P5FZSjQ5H5jq8kriDY1NzIwsjcwNLYyMzZXEeZXs20KEBNITS1KzU1MLUotg +pg4OKUaGBXrBQ5ZLSjce9CreaOi7OPs2LupQW2ux/ofxZWuPqx618uuzMC3MkS9S1l2/Xad Vq2rSQtvTKnX++TM3GI6e4WF00qThjuxk9SVVANvZbosTGrR/pd7vpXpRx/jyabAn3JnvDyl laU28m7fZN8rfPqe9bZDMl4phuw/S8wFGza8n7Rgr/QUJZbijERDLeai4kQA6SMzbD0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/26/2015 10:54 PM, Lee Jones wrote: > On Thu, 26 Mar 2015, Beomho Seo wrote: >> On 03/24/2015 05:38 PM, Krzysztof Kozlowski wrote: >>> 2015-03-24 9:01 GMT+01:00 Beomho Seo : >>>> On 03/10/2015 10:44 PM, Beomho Seo wrote: >>>>> On 03/09/2015 09:13 PM, Krzysztof Kozlowski wrote: >>>>>> On pon, 2015-03-09 at 20:46 +0900, Beomho Seo wrote: >>>>>>> On 03/09/2015 08:02 PM, Krzysztof Kozlowski wrote: >>>>>>>> 2015-03-09 1:35 GMT+01:00 Beomho Seo : >>>>>>>>> On 03/08/2015 05:13 AM, Sebastian Reichel wrote: >>>>>>>>>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote: >>>>>>>>>>> From: Beomho Seo >>>>>>>>>>> >>>>>>>>>>> This patch adds device driver of max77843 charger. This driver provide >>>>>>>>>>> initialize each charging mode(e.g. fast charge, top-off mode and constant >>>>>>>>>>> charging mode so on.). Additionally, control charging paramters to use >>>>>>>>>>> i2c interface. >>>>>>>>>>> >>>>>>>>>>> Cc: Sebastian Reichel >>>>>>>>>>> Signed-off-by: Beomho Seo >>>>>>>>>> >>>>>>>>>> Reviewed-By: Sebastian Reichel >>>>>>>>>> >>>>>>>>>> I can't take it as is, since it depends on the private header file >>>>>>>>>> of PATCHv1. >>>>>>>>>> >>>>>>>>>> -- Sebastian >>>>>>>>>> >>>>>>>>> >>>>>>>>> This patch reviewed by Sebastian. >>>>>>>>> Could you Please merge that your git tree ? >>>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> ... and again we are adding a new driver for very similar chipset to >>>>>>>> already supported. I looked at spec and the charger's registers are >>>>>>>> almost the same as for max77693. Their layout and addresses are the >>>>>>>> same. I see some minor differences, probably the most important would >>>>>>>> be different values current (fast-charge, top-off). But still 90% of >>>>>>>> registers are the same... Do we really have to add new driver? >>>>>>>> >>>>>>>> Best regards, >>>>>>>> Krzysztof >>>>>>>> >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Thank you for your comment. As you say, both chip set are similar. >>>>>>> But new driver need for support max77843. It is support different below >>>>>>> - Provide Battery presence information. >>>>>> >>>>>> Another set of power supply properties could be added for that chip. >>>>>> This way the get_property() function would be the same but actually the >>>>>> POWER_SUPPLY_PROP_PRESENT won't be called for max77693. >>>>>> >>>>>>> - Can OTG FET control. >>>>>> >>>>>> Where the OTG FET feature is it enabled in your driver? I couldn't find >>>>>> it. >>>>>> >>>>> >>>>> Sorry. This driver don't control OTG FET feature. >>>>> >>>>>>> - Bigger Fast charge current, Top Off current Threshold selection. >>>>>>> - Various and bigger OTG current limitation. >>>>>>> - Bigger primary charger termination voltage setting. >>>>>>> - Different maximum input current limit selection(Different step). >>>>>> >>>>>> Yes, I mentioned some of these differences (the Fast/top-off >>>>>> differences). These are differences in values so it does not require new >>>>>> driver. There is need to develop new driver just to support different >>>>>> current (3.0 A instead of 2.1 A) or voltage threshold. >>>>>> >>>>> >>>>> They are different charging current, OTG current limitation, top off current, >>>>> charging limitation value. In case OTG current limitation different not >>>>> limitation value but using register bit(max77843 use[7:6] max77693 use[7] >>>>> bit only). Even if this driver not support all feature, some register >>>>> different with max77693(support value, use register bit). >>>>> >>>>> If this driver will combined with max77693 may even be beneficial for >>>>> new Maxim driver. But the present, this driver is related with >>>>> max77843 core driver and max77843-regulator. So I hope this driver >>>>> merge first. And then will extend two driver(max77843 charger and max77693 charger). >>> >>> I still prefer merging common drivers into one instead of creating >>> some more of them. >>> However I understand your point and I am not entirely opposed against. >>> Especially that you invested quite a bit of time for developing this >>> and my feedback was quite late. To summarize I am fine with your >>> approach. >>> >>> Best regards, >>> Krzysztof >>> >> >> Dear Lee Jones, >> >> Could you please merge that your git tree ? > > Sorry, I'm lost. Why am I taking this though the MFD tree? What > patches are left? Where are they going? Am I taking any other > patches? > Max77843 charger driver is max77843 mfd core dependency. If you think this patch will suitable for battery tree(or other tree), I would like request for merge battery tree. Also, I will send again this patch and device tree binding document. Best regards, Beomho Seo