From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [RFC v1 06/15] vt-d: Extend struct iremap_entry to
 support VT-d Posted-Interrupts
Date: Fri, 27 Mar 2015 09:58:08 +0000
Message-ID: <551537C0020000780006E693@mail.emea.novell.com>
References: <1427286717-4093-1-git-send-email-feng.wu@intel.com>
	<1427286717-4093-7-git-send-email-feng.wu@intel.com>
	<55145768.8080400@citrix.com>
	<E959C4978C3B6342920538CF579893F002468154@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <E959C4978C3B6342920538CF579893F002468154@SHSMSX104.ccr.corp.intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Feng Wu <feng.wu@intel.com>
Cc: Yang Z Zhang <yang.z.zhang@intel.com>, Kevin Tian <kevin.tian@intel.com>, "keir@xen.org" <keir@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 27.03.15 at 02:53, <feng.wu@intel.com> wrote:
>> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
>> Sent: Friday, March 27, 2015 3:01 AM
>> On 25/03/15 12:31, Feng Wu wrote:
>> > --- a/xen/drivers/passthrough/vtd/iommu.h
>> > +++ b/xen/drivers/passthrough/vtd/iommu.h
>> > @@ -303,6 +303,18 @@ struct iremap_entry {
>> >               res_2   : 8,
>> >               dst     : 32;
>> >       }lo;
>> > +    struct {
>> > +        u64 p       : 1,
>> > +            fpd     : 1,
>> > +            res_1   : 6,
>> > +            avail   : 4,
>> > +            res_2   : 2,
>> > +            urg     : 1,
>> > +            im      : 1,
>> > +            vector  : 8,
>> > +            res_3   : 14,
>> > +            pda_l   : 26;
>> > +    }lo_intpost;
>> >     };
>> >     union {
>> >       u64 hi_val;
>> > @@ -312,6 +324,13 @@ struct iremap_entry {
>> >               svt     : 2,
>> >               res_1   : 44;
>> >       }hi;
>> > +    struct {
>> > +        u64 sid     : 16,
>> > +            sq      : 2,
>> > +            svt     : 2,
>> > +            res_1   : 12,
>> > +            pda_h   : 32;
>> > +    }hi_intpost;
>> 
>> I would prefer if this union was reformatted as I suggested in the
>> thread from your design doc, but I won't insist on it as a blocker to entry.
> 
> Thanks for the comments. I also considered your sugguestion on the Design
> doc, here is your proposal:
> 
> struct iremap_entry {
>     union {
>         struct { u64 lo, hi; };
>         struct { <bitfields> } norm; (names subject to improvement)
>         struct { <bitfields> } post;
>     };
> };
> 
> Seems in that way, we need to change some existing code to adapt to
> this new structure. I am okay with both of them, but can we listen
> some voices form some others? Is it okay for you?

I think this would be a good move, but in the end it's the VT-d
maintainers who got to decide.

Jan