From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC v1 14/15] Suppress posting interrupts when
 'SN' is set
Date: Fri, 27 Mar 2015 12:06:01 +0000
Message-ID: <551547A9.7090408@citrix.com>
References: <1427286717-4093-1-git-send-email-feng.wu@intel.com>
	<1427286717-4093-15-git-send-email-feng.wu@intel.com>
	<55146D5C.4000305@citrix.com>
	<E959C4978C3B6342920538CF579893F002469308@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <E959C4978C3B6342920538CF579893F002469308@SHSMSX104.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Wu, Feng" <feng.wu@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, "Tian,
	Kevin" <kevin.tian@intel.com>, "keir@xen.org" <keir@xen.org>, "JBeulich@suse.com" <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 27/03/15 03:00, Wu, Feng wrote:
>
>>>    static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector)
>>>    {
>>> +    int r, sn;
>>> +
>>>        if ( pi_test_and_set_pir(vector, &v->arch.hvm_vmx.pi_desc) )
>>>            return;
>>>
>>> +    /*
>>> +     * Currently, we don't support urgent interrupt, all interrupts
>>> +     * are recognized as non-urgent interrupt, so we cannot send
>>> +     * posted-interrupt when 'SN' is set.
>>> +     */
>>> +
>>> +    sn = pi_test_sn(&v->arch.hvm_vmx.pi_desc);
>> Is there anywhere which sets sn at all? I cant spot anywhere.
>>
> SN is set in [13/15] while vCPU is going to runnable state.

Then please do not set SN in the first place if we don't support it.

~Andrew