All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Gregor Jasny <gjasny@googlemail.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] libv4lconvert: Fix support for Y16 pixel format
Date: Fri, 27 Mar 2015 14:42:56 +0100	[thread overview]
Message-ID: <55155E60.6080505@redhat.com> (raw)
In-Reply-To: <1427386654-31906-1-git-send-email-ricardo.ribalda@gmail.com>

Hi,

On 26-03-15 17:17, Ricardo Ribalda Delgado wrote:
> Y16 is a little-endian format. The original implementation assumed that
> it was big-endian.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Thanks merged upstream, both into master and stable-1.6 branches.

Regards,

Hans

> ---
>   lib/libv4lconvert/rgbyuv.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/lib/libv4lconvert/rgbyuv.c b/lib/libv4lconvert/rgbyuv.c
> index 0f30192..75c42aa 100644
> --- a/lib/libv4lconvert/rgbyuv.c
> +++ b/lib/libv4lconvert/rgbyuv.c
> @@ -591,6 +591,9 @@ void v4lconvert_y16_to_rgb24(const unsigned char *src, unsigned char *dest,
>   		int width, int height)
>   {
>   	int j;
> +
> +	src++; /*Y16 is little endian*/
> +
>   	while (--height >= 0) {
>   		for (j = 0; j < width; j++) {
>   			*dest++ = *src;
> @@ -606,6 +609,8 @@ void v4lconvert_y16_to_yuv420(const unsigned char *src, unsigned char *dest,
>   {
>   	int x, y;
>
> +	src++; /*Y16 is little endian*/
> +
>   	/* Y */
>   	for (y = 0; y < src_fmt->fmt.pix.height; y++)
>   		for (x = 0; x < src_fmt->fmt.pix.width; x++){
>

      reply	other threads:[~2015-03-27 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 16:17 [PATCH] libv4lconvert: Fix support for Y16 pixel format Ricardo Ribalda Delgado
2015-03-27 13:42 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55155E60.6080505@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=gjasny@googlemail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.