From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YbUXj-0003G2-H1 for mharc-grub-devel@gnu.org; Fri, 27 Mar 2015 09:43:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbUXc-0003FR-Aq for grub-devel@gnu.org; Fri, 27 Mar 2015 09:43:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbUXX-0004C3-N9 for grub-devel@gnu.org; Fri, 27 Mar 2015 09:43:16 -0400 Received: from mail.emea.novell.com ([130.57.118.101]:40851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbUXX-0004Bu-Ef for grub-devel@gnu.org; Fri, 27 Mar 2015 09:43:11 -0400 Received: from EMEA1-MTA by mail.emea.novell.com with Novell_GroupWise; Fri, 27 Mar 2015 13:43:10 +0000 Message-Id: <55156C7E020000780006E98E@mail.emea.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.0.1 Date: Fri, 27 Mar 2015 13:43:10 +0000 From: "Jan Beulich" To: "Daniel Kiper" Subject: Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader References: <1422640462-28103-1-git-send-email-daniel.kiper@oracle.com> <1422640462-28103-6-git-send-email-daniel.kiper@oracle.com> <54E76C2F0200007800062262@mail.emea.novell.com> <20150327133228.GN8294@olila.local.net-space.pl> In-Reply-To: <20150327133228.GN8294@olila.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 130.57.118.101 Cc: Juergen Gross , grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 13:43:22 -0000 >>> On 27.03.15 at 14:32, wrote: > On Fri, Feb 20, 2015 at 04:17:35PM +0000, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > We need more fine grained knowledge about EFI environment and check >> > for EFI platform and EFI loader separately to properly support >> > multiboot2 protocol. >> >> ... because of ... (i.e. I can't see from the description what the >> separation is good for). Looking at the comments you placed >> aside the variables doesn't help me either. >> >> > In general Xen loaded by this protocol uses >> > memory mappings and loaded modules in simliar way to Xen loaded >> > by multiboot (v1) protocol. Hence, split efi_enabled to efi_platform >> > and efi_loader. >> >> And if I'm guessing things right, then introducing efi_loader but >> leaving efi_enabled alone (only converting where needed) would >=20 > efi_enabled is not fortunate name for new usage. Currently it means > that Xen binary have or does not have EFI support build in. However, > if we build in multiboot2 protocol into xen.gz then it means that > it can ran on legacy BIOS or EFI platform. So, I think that we > should rename efi_enabled to efi_platform because it will mean > that Xen runs on EFI platform or not. I disagree here. > efi_loader is used to differentiate between EFI native loader > and multiboot2 protocol. And I agree here. Jan