From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Wang Subject: Re: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer Date: Fri, 27 Mar 2015 17:03:14 +0100 Message-ID: <55157F42.1070303@profitbricks.com> References: <5512CFB0.1050108@profitbricks.com> <1427378940.21101.100.camel@redhat.com> <55142DFD.2060100@profitbricks.com> <1427387258.21101.124.camel@redhat.com> <55143AAC.8040206@profitbricks.com> <20150326211334.GA3359@obsidianresearch.com> <5515284A.3030106@profitbricks.com> <20150327155530.GA21778@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150327155530.GA21778-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , Moni Shoua , Or Gerlitz , Tatyana Nikolova , Steve Wise , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Jiri Kosina , Matan Barak , Majd Dibbiny List-Id: linux-rdma@vger.kernel.org On 03/27/2015 04:55 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 10:52:10AM +0100, Michael Wang wrote: >> [snip] > So, in principle, testing the device should almost make sense. The > device is the container for things like PD's MR's and QP's and those > things can migrate between the ports freely, so all post must share > the same attributes for those items. > > However.. AFAIK, we can have RoCEE and IB ports on the same device - > which makes that whole concept seem sort of like nonsense.. > > Anyhow, I would discourage testing the device. Each site has to be > examined and determine if it working with a single port and really > needs a port attribute (which may be a device attribute today) or if > it is doing something device wide and is checking if all ports support > X. I prefer Doug's proposal that these attributes should be setup by vendor at very beginning, unless the attributes keep changing... > >> Let's discuss and figure out the right name in the thread of >> v2 patch set, I guess there will be a lot to be correct :-P > Well, this is actually a hard job. This isn't a mechanical clean up, > each site has to be inspected and understood before it can be > migrated to the correct API. I've send out the RFC patch set, let's see if it is possible to settle some thing done ;-) Regards, Michael Wang > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422643AbbC0QDY (ORCPT ); Fri, 27 Mar 2015 12:03:24 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:34608 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932554AbbC0QDS (ORCPT ); Fri, 27 Mar 2015 12:03:18 -0400 Message-ID: <55157F42.1070303@profitbricks.com> Date: Fri, 27 Mar 2015 17:03:14 +0100 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jason Gunthorpe CC: Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , Moni Shoua , Or Gerlitz , Tatyana Nikolova , Steve Wise , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Jiri Kosina , Matan Barak , Majd Dibbiny , Dan Carpenter , Mel Gorman , Alex Estrin , Eric Dumazet , Erez Shitrit , Sagi Grimberg , Haggai Eran , Shachar Raindel , Mike Marciniszyn , Tom Tucker , Chuck Lever Subject: Re: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer References: <5512CFB0.1050108@profitbricks.com> <1427378940.21101.100.camel@redhat.com> <55142DFD.2060100@profitbricks.com> <1427387258.21101.124.camel@redhat.com> <55143AAC.8040206@profitbricks.com> <20150326211334.GA3359@obsidianresearch.com> <5515284A.3030106@profitbricks.com> <20150327155530.GA21778@obsidianresearch.com> In-Reply-To: <20150327155530.GA21778@obsidianresearch.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 04:55 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 10:52:10AM +0100, Michael Wang wrote: >> [snip] > So, in principle, testing the device should almost make sense. The > device is the container for things like PD's MR's and QP's and those > things can migrate between the ports freely, so all post must share > the same attributes for those items. > > However.. AFAIK, we can have RoCEE and IB ports on the same device - > which makes that whole concept seem sort of like nonsense.. > > Anyhow, I would discourage testing the device. Each site has to be > examined and determine if it working with a single port and really > needs a port attribute (which may be a device attribute today) or if > it is doing something device wide and is checking if all ports support > X. I prefer Doug's proposal that these attributes should be setup by vendor at very beginning, unless the attributes keep changing... > >> Let's discuss and figure out the right name in the thread of >> v2 patch set, I guess there will be a lot to be correct :-P > Well, this is actually a hard job. This isn't a mechanical clean up, > each site has to be inspected and understood before it can be > migrated to the correct API. I've send out the RFC patch set, let's see if it is possible to settle some thing done ;-) Regards, Michael Wang > > Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Wang Subject: Re: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer Date: Fri, 27 Mar 2015 17:03:14 +0100 Message-ID: <55157F42.1070303@profitbricks.com> References: <5512CFB0.1050108@profitbricks.com> <1427378940.21101.100.camel@redhat.com> <55142DFD.2060100@profitbricks.com> <1427387258.21101.124.camel@redhat.com> <55143AAC.8040206@profitbricks.com> <20150326211334.GA3359@obsidianresearch.com> <5515284A.3030106@profitbricks.com> <20150327155530.GA21778@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , Moni Shoua , Or Gerlitz , Tatyana Nikolova , Steve Wise , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Jiri Kosina , Matan Barak , Majd Dibbiny Return-path: In-Reply-To: <20150327155530.GA21778-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 03/27/2015 04:55 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 10:52:10AM +0100, Michael Wang wrote: >> [snip] > So, in principle, testing the device should almost make sense. The > device is the container for things like PD's MR's and QP's and those > things can migrate between the ports freely, so all post must share > the same attributes for those items. > > However.. AFAIK, we can have RoCEE and IB ports on the same device - > which makes that whole concept seem sort of like nonsense.. > > Anyhow, I would discourage testing the device. Each site has to be > examined and determine if it working with a single port and really > needs a port attribute (which may be a device attribute today) or if > it is doing something device wide and is checking if all ports support > X. I prefer Doug's proposal that these attributes should be setup by vendor at very beginning, unless the attributes keep changing... > >> Let's discuss and figure out the right name in the thread of >> v2 patch set, I guess there will be a lot to be correct :-P > Well, this is actually a hard job. This isn't a mechanical clean up, > each site has to be inspected and understood before it can be > migrated to the correct API. I've send out the RFC patch set, let's see if it is possible to settle some thing done ;-) Regards, Michael Wang > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html