From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Wang Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Date: Fri, 27 Mar 2015 17:15:42 +0100 Message-ID: <5515822E.2020207@profitbricks.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> <20150327160616.GA28412@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150327160616.GA28412-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin List-Id: linux-rdma@vger.kernel.org On 03/27/2015 05:06 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:48:22PM +0100, Michael Wang wrote: > >> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> index 3341754..fcd7558 100644 >> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> @@ -1655,7 +1655,7 @@ static void ipoib_add_one(struct ib_device *device) >> struct ipoib_dev_priv *priv; >> int s, e, p; >> >> - if (!rdma_transport_is_ib(device)) >> + if (!has_ipoib(device)) >> return; > This is a good example of a test that doesn't really make sense, IPoIB > is certainly a port specific attribute. According to my understanding, seems like the logical is: if 'device have no port need ipoib initialization' return > >> dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); >> @@ -1673,7 +1673,7 @@ static void ipoib_add_one(struct ib_device *device) >> } >> >> for (p = s; p <= e; ++p) { >> - if (!rdma_port_ll_is_ib(device, p)) >> + if (!cap_ipoib(device, p)) >> continue; > And down here we test every port. > > The routine should just test every port and do nothing if no ports > need IPoIB. And here since there are some initial work to do, it iterate all the port to find out which one need to be initialized. > >> dev = ipoib_add_port("ib%d", device, p); >> if (!IS_ERR(dev)) { >> @@ -1690,7 +1690,7 @@ static void ipoib_remove_one(struct ib_device *device) >> struct ipoib_dev_priv *priv, *tmp; >> struct list_head *dev_list; >> >> - if (!rdma_transport_is_ib(device)) >> + if (!has_ipoib(device)) >> return; > This test should be made redundant by having ib_get_client_data return > null if ipoib_add_one didn't do anything. Maybe that already happens? Here if we have done nothing when add a device, then nothing need to be cleanup when remove it. I'm not sure if it's a good idea, but seems like the idea is use twice check on different level to save some cycles? Regards, Michael Wang > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbbC0QPu (ORCPT ); Fri, 27 Mar 2015 12:15:50 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36625 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbbC0QPq (ORCPT ); Fri, 27 Mar 2015 12:15:46 -0400 Message-ID: <5515822E.2020207@profitbricks.com> Date: Fri, 27 Mar 2015 17:15:42 +0100 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jason Gunthorpe CC: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin , Doug Ledford , Eric Dumazet , Erez Shitrit , Sagi Grimberg , Haggai Eran , Shachar Raindel , Mike Marciniszyn , Steve Wise , Tom Tucker , Chuck Lever Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> <20150327160616.GA28412@obsidianresearch.com> In-Reply-To: <20150327160616.GA28412@obsidianresearch.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 05:06 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:48:22PM +0100, Michael Wang wrote: > >> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> index 3341754..fcd7558 100644 >> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> @@ -1655,7 +1655,7 @@ static void ipoib_add_one(struct ib_device *device) >> struct ipoib_dev_priv *priv; >> int s, e, p; >> >> - if (!rdma_transport_is_ib(device)) >> + if (!has_ipoib(device)) >> return; > This is a good example of a test that doesn't really make sense, IPoIB > is certainly a port specific attribute. According to my understanding, seems like the logical is: if 'device have no port need ipoib initialization' return > >> dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); >> @@ -1673,7 +1673,7 @@ static void ipoib_add_one(struct ib_device *device) >> } >> >> for (p = s; p <= e; ++p) { >> - if (!rdma_port_ll_is_ib(device, p)) >> + if (!cap_ipoib(device, p)) >> continue; > And down here we test every port. > > The routine should just test every port and do nothing if no ports > need IPoIB. And here since there are some initial work to do, it iterate all the port to find out which one need to be initialized. > >> dev = ipoib_add_port("ib%d", device, p); >> if (!IS_ERR(dev)) { >> @@ -1690,7 +1690,7 @@ static void ipoib_remove_one(struct ib_device *device) >> struct ipoib_dev_priv *priv, *tmp; >> struct list_head *dev_list; >> >> - if (!rdma_transport_is_ib(device)) >> + if (!has_ipoib(device)) >> return; > This test should be made redundant by having ib_get_client_data return > null if ipoib_add_one didn't do anything. Maybe that already happens? Here if we have done nothing when add a device, then nothing need to be cleanup when remove it. I'm not sure if it's a good idea, but seems like the idea is use twice check on different level to save some cycles? Regards, Michael Wang > > Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Wang Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Date: Fri, 27 Mar 2015 17:15:42 +0100 Message-ID: <5515822E.2020207@profitbricks.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> <20150327160616.GA28412@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin Return-path: In-Reply-To: <20150327160616.GA28412-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 03/27/2015 05:06 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:48:22PM +0100, Michael Wang wrote: > >> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> index 3341754..fcd7558 100644 >> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c >> @@ -1655,7 +1655,7 @@ static void ipoib_add_one(struct ib_device *device) >> struct ipoib_dev_priv *priv; >> int s, e, p; >> >> - if (!rdma_transport_is_ib(device)) >> + if (!has_ipoib(device)) >> return; > This is a good example of a test that doesn't really make sense, IPoIB > is certainly a port specific attribute. According to my understanding, seems like the logical is: if 'device have no port need ipoib initialization' return > >> dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); >> @@ -1673,7 +1673,7 @@ static void ipoib_add_one(struct ib_device *device) >> } >> >> for (p = s; p <= e; ++p) { >> - if (!rdma_port_ll_is_ib(device, p)) >> + if (!cap_ipoib(device, p)) >> continue; > And down here we test every port. > > The routine should just test every port and do nothing if no ports > need IPoIB. And here since there are some initial work to do, it iterate all the port to find out which one need to be initialized. > >> dev = ipoib_add_port("ib%d", device, p); >> if (!IS_ERR(dev)) { >> @@ -1690,7 +1690,7 @@ static void ipoib_remove_one(struct ib_device *device) >> struct ipoib_dev_priv *priv, *tmp; >> struct list_head *dev_list; >> >> - if (!rdma_transport_is_ib(device)) >> + if (!has_ipoib(device)) >> return; > This test should be made redundant by having ib_get_client_data return > null if ipoib_add_one didn't do anything. Maybe that already happens? Here if we have done nothing when add a device, then nothing need to be cleanup when remove it. I'm not sure if it's a good idea, but seems like the idea is use twice check on different level to save some cycles? Regards, Michael Wang > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html