Re: [RFC PATCH v2 16/22] xen/arm: its: implement hw_irq_controller for LPIs

[Julien Grall <julien.grall@linaro.org>]

Hello Vijay,

On 19/03/15 14:38, vijay.kilari@gmail.com wrote:
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 2b406e6..1b3ecd7 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -40,6 +40,7 @@
>  #include <asm/device.h>
>  #include <asm/gic.h>
>  #include <asm/gic_v3_defs.h>
> +#include <asm/gic-its.h>
>  #include <asm/cpufeature.h>
>  
>  struct rdist_region {
> @@ -427,12 +428,18 @@ static void gicv3_poke_irq(struct irq_desc *irqd, u32 offset)
>  
>  static void gicv3_unmask_irq(struct irq_desc *irqd)
>  {
> -    gicv3_poke_irq(irqd, GICD_ISENABLER);
> +    if ( is_lpi(irqd->irq) )
> +        lpi_set_config(irqd, 1);
> +    else
> +        gicv3_poke_irq(irqd, GICD_ISENABLER);
>  }

While Stefano was asking to move the hw_irq_controller in gic-v3.c, I
believe he didn't meant merging them.

The goal of the hw_irq_control is to avoid unnecessary check like the
"if ( is_lpi(...) ) /* LPI handling */ else /* GICv3 handling */"

Regards,

-- 
Julien Grall