From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybsl8-0001Rn-Ck for qemu-devel@nongnu.org; Sat, 28 Mar 2015 11:34:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ybsl3-0002ar-Dv for qemu-devel@nongnu.org; Sat, 28 Mar 2015 11:34:50 -0400 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:34981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybsl2-0002ZN-Td for qemu-devel@nongnu.org; Sat, 28 Mar 2015 11:34:45 -0400 Received: by wgdm6 with SMTP id m6so128112757wgd.2 for ; Sat, 28 Mar 2015 08:34:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5516CA10.2010307@redhat.com> Date: Sat, 28 Mar 2015 16:34:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-12-git-send-email-dgilbert@redhat.com> <20150310054725.GC11973@voom.redhat.com> In-Reply-To: <20150310054725.GC11973@voom.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com On 10/03/2015 06:47, David Gibson wrote: >> > +void migrate_send_rp_message(MigrationIncomingState *mis, >> > + enum mig_rpcomm_cmd cmd, >> > + uint16_t len, uint8_t *data) > Using (void *) for data would avoid casts in a bunch of the callers. Could also use uint8_t in the callers and replace cpu_to_be32 with stl_be_p. This makes it harder to send stuff with the wrong endianness. Paolo