From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbbC2RfK (ORCPT ); Sun, 29 Mar 2015 13:35:10 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:48411 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbbC2RfH (ORCPT ); Sun, 29 Mar 2015 13:35:07 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <551837C4.6080307@mev.co.uk> Date: Sun, 29 Mar 2015 18:35:00 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org CC: H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org Subject: Re: [PATCH 62/86] staging/comedi: use uapi/linux/pci_ids.h directly References: <1427635734-24786-1-git-send-email-mst@redhat.com> <1427635734-24786-63-git-send-email-mst@redhat.com> In-Reply-To: <1427635734-24786-63-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/03/15 14:42, Michael S. Tsirkin wrote: > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, > use the new header directly so we can drop > the wrapper in include/linux/pci_ids.h. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/staging/comedi/comedidev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h > index e138eb0..1c3ac0b 100644 > --- a/drivers/staging/comedi/comedidev.h > +++ b/drivers/staging/comedi/comedidev.h > @@ -556,7 +556,7 @@ void comedi_driver_unregister(struct comedi_driver *); > /* comedi_pci.c - comedi PCI driver specific functions */ > > /* > - * PCI Vendor IDs not in > + * PCI Vendor IDs not in > */ > #define PCI_VENDOR_ID_KOLTER 0x1001 > #define PCI_VENDOR_ID_ICP 0x104c > Hi Michael, I don't understand why you need to change this and lots of other source code just to move a header into uapi when it hasn't been necessary for other headers that have been moved into uapi. Surely kernel code can still use #include even though the header file is located at "include/uapi/linux/pci_ids.h"? Also, this patch doesn't apply to the latest linux-next. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-