From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbbC3AEI (ORCPT ); Sun, 29 Mar 2015 20:04:08 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21949 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbbC3AEE (ORCPT ); Sun, 29 Mar 2015 20:04:04 -0400 Message-ID: <551892EC.6030209@oracle.com> Date: Mon, 30 Mar 2015 08:03:56 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= , xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, jennifer.herbert@citrix.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() References: <1427372161-4964-1-git-send-email-bob.liu@oracle.com> <1427372161-4964-2-git-send-email-bob.liu@oracle.com> <5514269D.6050905@citrix.com> <20150328004459.GA14373@l.oracle.com> In-Reply-To: <20150328004459.GA14373@l.oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote: >> El 26/03/15 a les 13.16, Bob Liu ha escrit: >>> There are several place using gnttab async unmap and wait for >>> completion, so move the common code to a function >>> gnttab_unmap_refs_async_wait_completion(). >>> >>> Signed-off-by: Bob Liu >> >> For the blkback parts: >> >> Acked-by: Roger Pau Monné >> >> Although, as David already said, I think we should do better than BUG_ON >> on error. > This patch only keeps the existing behaviour the same as before. I prefer to make new patches(based on this one) if want to change the behaviour. > Have an 'stuck deferred pages' list and an timer to occasionally > flush them out? Something similar to 569ca5b3f94cd0b3295ec5943aa457cf4a4f6a3a > "xen/gnttab: add deferred freeing logic" ? Sounds like a good idea. -- Regards, -Bob