From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcV6J-0006Ev-3z for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:31:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcV6F-0002gI-UP for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:31:15 -0400 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:34399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcV6F-0002gC-Mb for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:31:11 -0400 Received: by wgbdm7 with SMTP id dm7so58477793wgb.1 for ; Mon, 30 Mar 2015 01:31:11 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <551909CA.7080605@redhat.com> Date: Mon, 30 Mar 2015 10:31:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-31-git-send-email-dgilbert@redhat.com> <20150323042012.GN25043@voom.fritz.box> <20150326110517.GA2370@work-vm> In-Reply-To: <20150326110517.GA2370@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com On 26/03/2015 12:05, Dr. David Alan Gilbert wrote: >>> > > + qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); >>> > > + *old_vm_running = runstate_is_running(); >> > >> > I think that needs some explanation. Why are you doing a wakeup on >> > the source host? > This matches the existing code in migration_thread for the end of precopy; > Paolo's explanation of what it does is here: > https://lists.gnu.org/archive/html/qemu-devel/2014-08/msg04880.html The more I look at it, the more I'm convinced it's working by chance or not working at all. Here we probably need to do only the notifier_list_notify + qapi_event_send_wakeup. Paolo