From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcbXB-0001ZF-0t for qemu-devel@nongnu.org; Mon, 30 Mar 2015 11:23:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcbX5-0008Ut-UY for qemu-devel@nongnu.org; Mon, 30 Mar 2015 11:23:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcbX5-0008Uk-O7 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 11:23:19 -0400 Message-ID: <55196A65.2020208@redhat.com> Date: Mon, 30 Mar 2015 09:23:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-2-git-send-email-eblake@redhat.com> <87vbhpc4j7.fsf@blackfin.pond.sub.org> <55131689.8030107@redhat.com> <87619o9owc.fsf@blackfin.pond.sub.org> In-Reply-To: <87619o9owc.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KI3hDpgHe2indj07pDrbQ6BUVLve7UiqX" Subject: Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, wenchaoqemu@gmail.com, Michael Roth , qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KI3hDpgHe2indj07pDrbQ6BUVLve7UiqX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/26/2015 01:52 AM, Markus Armbruster wrote: >>>> I'm not sure if it is okay to assert GPLv2+ licensing without an >>>> explicit Copyright, but as I am not the original author, I don't >>>> know who to attribute any original Copyright to. Advice? Should >>>> I split the license addition to a separate patch? >> >> No thoughts to this question? >=20 > Missed it. >=20 > I wish we didn't need to clutter copyright and licensing boiler plate > everywhere, but I accept it's the prudent thing to do in a tree with so= > many differently licensed parts. >=20 > Making GPLv2+ explicit is obviously fine, because anything without an > explicit licensing note is GPLv2+ (see ./LICENSE). That leaves the > copyright part, as you say. >=20 > According to git-log, the file was created by Michael Roth. git-blame > blames 219 out of 590 lines in current master on his initial commit. >=20 > $ git-blame -w master docs/qapi-code-gen.txt | cut -c 11-28 | sort | un= iq -c | sort -nr Nice, but the 'cut' renders it not quite reusable when column widths vary on other files or authorship information. 'git blame --help' sugges= ts: kept by the reader. The --line-porcelain option can be used to out= put full commit information for each line, allowing simpler (but less efficient) usage like: # count the number of lines attributed to each author git blame --line-porcelain file | sed -n 's/^author //p' | sort | uniq -c | sort -rn So with the updated formula, I also checked doc/qmp/qmp-spec.txt: 201 Luiz Capitulino 55 Markus Armbruster 17 Paolo Bonzini which is entirely Red Hat (a bit easier to handle). >=20 > If you want to add a copyright note, I suggest to steal one from > Michael's work elsewhere, and update it for later major contributors. >=20 > Here's my stab at it: >=20 > =3D How to use the QAPI code generator =3D >=20 > Copyright IBM Corp. 2011 > Copyright (C) 2012-2015 Red Hat, Inc. >=20 > Authors: > Michael Roth > Kevin Wolf > Markus Armbruster > Eric Blake >=20 > This work is licensed under the terms of the GNU GPL, version 2 or = later. > See the COPYING file in the top-level directory. >=20 > =3D=3D Introduction =3D=3D >=20 > QAPI is a native C API within QEMU which provides management-level > functionality to internal and external users. For external >=20 > The Authors paragraph is informational and could be omitted without > compromising the copyright note. I prefer omitting Authors information (it is too easy to become stale). I'll split this into a separate patch, as part of my v6. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KI3hDpgHe2indj07pDrbQ6BUVLve7UiqX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVGWplAAoJEKeha0olJ0Nqx+8H/1P9/MZ6IN9fMGRS9yDWJYwu YGrUpiw9OxG3rd0sZKIT8CMTYVWR6tpbHvo1SRIoUTL7d6ggx0O6GA97D6Rt3n3j GjHDwCvsaqWr+ms2ZFfAPAhwwgqNPn2b4Q8QaIITa6xAgYYnkRzwI3Tz5k04SFGO lXQJRr9Pmfhdy6dJQrJd4XALjb3U4zQ76XlDlvU7Sm/H7HmPcDC/vmF0und2Igq2 Pgt3CYRQwZiiY/locTT3WILa/xn9Au5O0VTKTA3jzuIHJbY1+BkXOLLVi9xrIAf8 JPlDJnMh03UXyWZzKjpxPmgtSBFGdsX4zSiHDFCekNh49SJ7opu/f6KtG+4xSU4= =Hl1Q -----END PGP SIGNATURE----- --KI3hDpgHe2indj07pDrbQ6BUVLve7UiqX--