From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753438AbbC3Tqg (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 15:46:36 -0400
Received: from mail-ig0-f179.google.com ([209.85.213.179]:33674 "EHLO
	mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751990AbbC3Tqe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 15:46:34 -0400
Message-ID: <5519A818.7080903@gmail.com>
Date: Mon, 30 Mar 2015 13:46:32 -0600
From: David Ahern <dsahern@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>
CC: Stephane Eranian <eranian@google.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Jiri Olsa <jolsa@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] perf, record: Add clockid parameter
References: <tip-34f439278cef7b1177f8ce24f9fc81dfc6221d3b@git.kernel.org> <20150327143201.GG21418@twins.programming.kicks-ass.net> <55158F25.9040100@gmail.com> <20150327172059.GK23123@twins.programming.kicks-ass.net> <551594DD.7050705@gmail.com> <20150327201534.GD6291@redhat.com> <20150327215942.GL23123@twins.programming.kicks-ass.net> <CABPqkBR_ou8E01kRmDOBb72ngcdzBkfVPNUj71XWnsYE6i0Bdg@mail.gmail.com> <20150328075549.GG27490@worktop.programming.kicks-ass.net> <551988F6.8000501@gmail.com> <20150330193411.GG23123@twins.programming.kicks-ass.net>
In-Reply-To: <20150330193411.GG23123@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/30/15 1:34 PM, Peter Zijlstra wrote:
>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>> index 1abf6919b8a2..27679ab38511 100644
>> --- a/tools/perf/util/evsel.c
>> +++ b/tools/perf/util/evsel.c
>> @@ -766,7 +766,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct
>> record_opts *opts)
>>      if (opts->clockid >= 0) {
>>          attr->use_clockid = 1;
>>          attr->clockid = opts->clockid;
>> -   }
>> +   } else
>> +       attr->clockid = -1;
>>   }
>
> No, we must not have a !0 value in ->clockid when we do not set
> use_clockid. The kernel checks for nonzero tail values.
>

oops, missed that -- use_clockid is part of the attr so it will be in 
the file header.

David