From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754042AbbC3U2S (ORCPT ); Mon, 30 Mar 2015 16:28:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38762 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753215AbbC3U2Q (ORCPT ); Mon, 30 Mar 2015 16:28:16 -0400 Message-ID: <5519B1D1.5060503@redhat.com> Date: Mon, 30 Mar 2015 14:28:01 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Mueller , qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org CC: Eduardo Habkost , Gleb Natapov , Alexander Graf , Christian Borntraeger , Daniel Hansel , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Richard Henderson , Andreas Faerber Subject: Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions References: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com> <1427725708-52100-13-git-send-email-mimu@linux.vnet.ibm.com> In-Reply-To: <1427725708-52100-13-git-send-email-mimu@linux.vnet.ibm.com> OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/30/2015 08:28 AM, Michael Mueller wrote: > The patch adds optional parameters to the QMP command query-cpu-definit= ions. > Thus the signature of routine arch_query_cpu_definitions needs to be ch= anged > for the stub function and all target implementations: >=20 > target-arm > target-i386 > target-ppc > target-s390 >=20 > Signed-off-by: Michael Mueller > --- > +++ b/qapi-schema.json > @@ -2532,21 +2532,31 @@ > # > # @name: the name of the CPU definition > # > +# @default: #optional defines if cpu model is the default (since 2.4) Reads poorly. How about: # @default: #optional true if cpu model is the default, omitted if false (since 2.4) > +# > +# @runnable: #optional defines if cpu model is runnable (since 2.4) Similarly: # @runnable: #optional true if cpu model is runnable, omitted if false (since 2.4) > +# > # Since: 1.2.0 > ## > { 'type': 'CpuDefinitionInfo', > - 'data': { 'name': 'str' } } > + 'data': { 'name': 'str', '*is-default': 'bool', '*runnable': 'bool' = } } > =20 > ## > # @query-cpu-definitions: > # > # Return a list of supported virtual CPU definitions > # > +# @machine: #optional machine type (since 2.4) > +# > +# @accel: #optional accelerator id (since 2.4) Maybe mention that these two fields are for filtering results. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVGbHRAAoJEKeha0olJ0NqLJcH/Asu74Bf16iPO/zOTs0J3I1T w1lm0WOv24eARofEZIA1FA2q0XkrWqaG61OaBMnytLqV4ogD5mk9lJzvxuiPi2wg NeuLyXtydDMvSsLwCsNZVNM0hTBrxK+JRm20DqSEflyVT4TEZPNFdCeHqZsys41+ 6IhIpT+cB4beZy2ks5lcVc7x4TU3XKsYdSEbmkARkD/N3IwboJKO0U0mV8G8zfz9 9hFitDjybzl/r+FqllOwK/Skql1DIRR65DhfOgz+vlLgxgcS6Itq/+fiAUtjoUI1 tTu/o6VgHGTD7KE4QSaIB8ncNC9nAk5h8vbcyDPCkXa7zMqVqklKrS97R9ibrnc= =dheX -----END PGP SIGNATURE----- --XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcgID-0008Be-Sz for qemu-devel@nongnu.org; Mon, 30 Mar 2015 16:28:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcgI8-0004kA-0G for qemu-devel@nongnu.org; Mon, 30 Mar 2015 16:28:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcgI7-0004jo-Ow for qemu-devel@nongnu.org; Mon, 30 Mar 2015 16:28:11 -0400 Message-ID: <5519B1D1.5060503@redhat.com> Date: Mon, 30 Mar 2015 14:28:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com> <1427725708-52100-13-git-send-email-mimu@linux.vnet.ibm.com> In-Reply-To: <1427725708-52100-13-git-send-email-mimu@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0" Subject: Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Mueller , qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Cornelia Huck , Eduardo Habkost , Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Daniel Hansel , Paolo Bonzini , Andreas Faerber , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/30/2015 08:28 AM, Michael Mueller wrote: > The patch adds optional parameters to the QMP command query-cpu-definit= ions. > Thus the signature of routine arch_query_cpu_definitions needs to be ch= anged > for the stub function and all target implementations: >=20 > target-arm > target-i386 > target-ppc > target-s390 >=20 > Signed-off-by: Michael Mueller > --- > +++ b/qapi-schema.json > @@ -2532,21 +2532,31 @@ > # > # @name: the name of the CPU definition > # > +# @default: #optional defines if cpu model is the default (since 2.4) Reads poorly. How about: # @default: #optional true if cpu model is the default, omitted if false (since 2.4) > +# > +# @runnable: #optional defines if cpu model is runnable (since 2.4) Similarly: # @runnable: #optional true if cpu model is runnable, omitted if false (since 2.4) > +# > # Since: 1.2.0 > ## > { 'type': 'CpuDefinitionInfo', > - 'data': { 'name': 'str' } } > + 'data': { 'name': 'str', '*is-default': 'bool', '*runnable': 'bool' = } } > =20 > ## > # @query-cpu-definitions: > # > # Return a list of supported virtual CPU definitions > # > +# @machine: #optional machine type (since 2.4) > +# > +# @accel: #optional accelerator id (since 2.4) Maybe mention that these two fields are for filtering results. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVGbHRAAoJEKeha0olJ0NqLJcH/Asu74Bf16iPO/zOTs0J3I1T w1lm0WOv24eARofEZIA1FA2q0XkrWqaG61OaBMnytLqV4ogD5mk9lJzvxuiPi2wg NeuLyXtydDMvSsLwCsNZVNM0hTBrxK+JRm20DqSEflyVT4TEZPNFdCeHqZsys41+ 6IhIpT+cB4beZy2ks5lcVc7x4TU3XKsYdSEbmkARkD/N3IwboJKO0U0mV8G8zfz9 9hFitDjybzl/r+FqllOwK/Skql1DIRR65DhfOgz+vlLgxgcS6Itq/+fiAUtjoUI1 tTu/o6VgHGTD7KE4QSaIB8ncNC9nAk5h8vbcyDPCkXa7zMqVqklKrS97R9ibrnc= =dheX -----END PGP SIGNATURE----- --XWT1U9SnCRBQTvbAw9qQJQ8pVQt7MPpK0--