From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YchBz-0006vE-50 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:25:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YchBv-00082i-3b for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:25:55 -0400 Message-ID: <5519BF52.7000409@web.de> Date: Mon, 30 Mar 2015 23:25:38 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <1425615506-1829-6-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1425615506-1829-6-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq" and "pic" hmp commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, mst@redhat.com, andreas.faerber@web.de, lcapitulino@redhat.com Cc: blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 06.03.2015 um 05:18 schrieb David Gibson: > Currently all ppc targets rely on fallback code in monitor.c to implement > the "irq" and "pic" hmp commands, by calling into the i8259 code. For the > PReP machine type, which does usually have an ISA bridge and legacy IO, > including an i8259, this patch correctly sets the MachineClass callbacks > to implement those commands properly without the fallback. > > In fact PReP is the only ppc machine for which the i8259 implementation > of those hmp commands makes sense. The other machine types won't typically > have an i8259 at all. So we can remove the fallback case from the monitor > meaning that other ppc targets will correctly implement those commands > as no-ops. > > Signed-off-by: David Gibson > --- > hw/ppc/prep.c | 2 ++ > monitor.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Andreas Färber Thanks, Andreas