From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YchJk-0000Mc-CT for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:33:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YchJf-0001LD-NQ for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:33:56 -0400 Message-ID: <5519C137.3070107@web.de> Date: Mon, 30 Mar 2015 23:33:43 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <1425615506-1829-5-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1425615506-1829-5-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, mst@redhat.com, lcapitulino@redhat.com Cc: blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 06.03.2015 um 05:18 schrieb David Gibson: > The more commonly used ppc machine types: spapr, and newworld Mac have > already been converted to the newer MachineClass representation, but some > others still use QEMUMachine. > > This patch cleans things up slightly, by converting the "prep" machine > type to the new style. > > Signed-off-by: David Gibson > --- > hw/ppc/prep.c | 30 +++++++++++++++++++++--------- > 1 file changed, 21 insertions(+), 9 deletions(-) > > diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c > index 15df7f3..dfc8689 100644 > --- a/hw/ppc/prep.c > +++ b/hw/ppc/prep.c > @@ -44,6 +44,8 @@ > #include "exec/address-spaces.h" > #include "elf.h" > > +#define TYPE_PREP_MACHINE "PReP-machine" [snip] qemu_register_machine() generated the type name by concatenating QEMUMachine::name with "-machine", so this should be "prep-machine". Otherwise looks great. Thanks, Andreas