From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YchWu-0004wA-Vd for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:47:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YchWr-0005jF-P3 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:47:32 -0400 Message-ID: <5519C46F.5050309@suse.de> Date: Mon, 30 Mar 2015 23:47:27 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <1425615506-1829-4-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1425615506-1829-4-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, mst@redhat.com, andreas.faerber@web.de, lcapitulino@redhat.com Cc: blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 06.03.2015 um 05:18 schrieb David Gibson: > Currently PC machine types rely on fallback code in the monitor > implementation to correctly implement these hmp commands. Now that we = have > MachineClass callbacks to control this properly, instantiate them in > pc_generic_machine_class_init(). >=20 > Since this sets the MachineClass callbacks correctly for all x86 machin= e > types, we can now remove the TARGET_I386 fallback case from the monitor > code. >=20 > Signed-off-by: David Gibson Reviewed-by: Andreas F=E4rber Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)