From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 06/15] hwmon: (it87) Add support for IT8620E
Date: Mon, 30 Mar 2015 21:50:37 +0000 [thread overview]
Message-ID: <5519C52D.2060608@roeck-us.net> (raw)
In-Reply-To: <1427697235-23566-7-git-send-email-linux@roeck-us.net>
On 03/29/2015 11:33 PM, Guenter Roeck wrote:
> IT8620E is mostly compatible to IT7828F. Add generic support for it.
>
> IT8620E supports up to 6 fan tachometers and 6 pwm controls.
> Support for the 6th tachometer and for the additional pwm controls
> are addded in separate patches.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
[ ... ]
> + } else if (sio_data->type = it8620) {
> + int reg;
> +
> + superio_select(GPIO);
> +
> + /* Check for fan4, fan5 */
> + reg = superio_inb(IT87_SIO_GPIO2_REG);
To safe reviewers some time ... IT87_SIO_GPIO2_REG is only introduced
in a later patch, breaking ability to bisect. I fixed it up.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2015-03-30 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 6:33 [lm-sensors] [PATCH 06/15] hwmon: (it87) Add support for IT8620E Guenter Roeck
2015-03-30 21:50 ` Guenter Roeck [this message]
2015-04-01 14:03 ` Jean Delvare
2015-04-01 14:10 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5519C52D.2060608@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.