From: "Andreas Färber" <afaerber@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] ARM: Add ARMv7-M support
Date: Tue, 31 Mar 2015 00:06:29 +0200 [thread overview]
Message-ID: <5519C8E5.2030109@suse.de> (raw)
In-Reply-To: <20150305153236.GS25373@bill-the-cat>
Am 05.03.2015 um 16:32 schrieb Tom Rini:
> On Sun, Mar 01, 2015 at 12:44:39PM +0100, Kamil Lulko wrote:
>
>> Signed-off-by: Kamil Lulko <rev13@wp.pl>
> [snip]
>> diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S
> [snip]
>> @@ -66,15 +69,30 @@ ENTRY(_main)
>> #else
>> ldr sp, =(CONFIG_SYS_INIT_SP_ADDR)
>> #endif
>> +#if defined(CONFIG_CPU_V7M) /* v7M forbids using SP as BIC destination */
>> + mov r3, sp
>> + bic r3, r3, #7
>> + mov sp, r3
>> +#else
>> bic sp, sp, #7 /* 8-byte alignment for ABI compliance */
>> +#endif
>
> There's 4 places where this change comes in. Albert, what do you think
> about always just doing this in 3 instructions with a comment in the
> first instance about v7-M support?
I remember running into problems like these when working on STM32F429
support late last year and I adopted some helper macros from Linux, I
believe. The same problem existed in U-Boot's private libgcc code.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG N?rnberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150331/4417dbf7/attachment.sig>
next prev parent reply other threads:[~2015-03-30 22:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 11:44 [U-Boot] [PATCH 0/4] Add support for stm32f429-discovery board Kamil Lulko
2015-03-01 11:44 ` [U-Boot] [PATCH 1/4] ARM: Add ARMv7-M support Kamil Lulko
2015-03-05 15:32 ` Tom Rini
2015-03-30 22:06 ` Andreas Färber [this message]
2015-04-01 0:55 ` Tom Rini
2015-04-23 13:14 ` [U-Boot] [U-Boot,1/4] " Tom Rini
2015-03-01 11:44 ` [U-Boot] [PATCH 2/4] ARMv7M: Add STM32F4 support Kamil Lulko
2015-03-05 15:34 ` Tom Rini
2015-04-23 13:14 ` [U-Boot] [U-Boot,2/4] " Tom Rini
2015-03-01 11:44 ` [U-Boot] [PATCH 3/4] stm32f4: Add serial driver Kamil Lulko
2015-03-05 15:34 ` Tom Rini
2015-04-23 13:14 ` [U-Boot] [U-Boot,3/4] " Tom Rini
2015-03-01 11:44 ` [U-Boot] [PATCH 4/4] stm32f4: Add support for stm32f429-discovery board Kamil Lulko
2015-03-05 15:35 ` Tom Rini
2015-04-23 13:14 ` [U-Boot] [U-Boot, " Tom Rini
2015-03-25 4:07 ` [U-Boot] [PATCH 0/4] " Chanwoo Choi
2015-03-25 16:58 ` Tom Rini
2015-03-26 13:47 ` Kamil Lulko
2015-03-26 14:07 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5519C8E5.2030109@suse.de \
--to=afaerber@suse.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.