From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753703AbbC3WYf (ORCPT ); Mon, 30 Mar 2015 18:24:35 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:32943 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbbC3WYd (ORCPT ); Mon, 30 Mar 2015 18:24:33 -0400 Message-ID: <5519CD1F.1000300@gmail.com> Date: Mon, 30 Mar 2015 16:24:31 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Stephane Eranian , linux-kernel@vger.kernel.org CC: acme@redhat.com, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, cel@us.ibm.com, sukadev@linux.vnet.ibm.com, sonnyrao@chromium.org, johnmccutchan@google.com, adrian.hunter@intel.com, pawel.moll@arm.com Subject: Re: [PATCH v6 1/4] perf,record: Add clockid parameter References: <1427753974-13380-1-git-send-email-eranian@google.com> <1427753974-13380-2-git-send-email-eranian@google.com> In-Reply-To: <1427753974-13380-2-git-send-email-eranian@google.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/30/15 4:19 PM, Stephane Eranian wrote: > @@ -761,6 +762,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) > attr->disabled = 0; > attr->enable_on_exec = 0; > } > + > + if (opts->clockid >= 0) { > + attr->use_clockid = 1; > + attr->clockid = opts->clockid; > + } else > + attr->clockid = -1; > } The else part needs to be removed (can't set clockid to -1). And then ... > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index fb43215..164441a 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -1098,6 +1098,8 @@ static void print_event_desc(struct perf_header *ph, int fd, FILE *fp) > } > fprintf(fp, " }"); > } > + fprintf(fp, ", clockid = %d", evsel->attr.clockid); > + this should be prefaced with: if (evsel->attr.use_clockid) (use_clockid bit says whether the clockid value was set)