From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yd5lj-00005K-3M for qemu-devel@nongnu.org; Tue, 31 Mar 2015 19:40:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yd5lf-0003KZ-OQ for qemu-devel@nongnu.org; Tue, 31 Mar 2015 19:40:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yd5lf-0003KP-Gs for qemu-devel@nongnu.org; Tue, 31 Mar 2015 19:40:23 -0400 Message-ID: <551B3063.3030103@redhat.com> Date: Tue, 31 Mar 2015 17:40:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-7-git-send-email-eblake@redhat.com> <87a8yz51uc.fsf@blackfin.pond.sub.org> <55140EFD.805@redhat.com> <87k2y3yclk.fsf@blackfin.pond.sub.org> <5519D201.5040304@redhat.com> In-Reply-To: <5519D201.5040304@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XaVBwHvhpavXLa2oNbBmKJSxKF73o3ri1" Subject: Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, wenchaoqemu@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XaVBwHvhpavXLa2oNbBmKJSxKF73o3ri1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/30/2015 04:45 PM, Eric Blake wrote: > On 03/26/2015 09:58 AM, Markus Armbruster wrote: >=20 >>>> /home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line a= t EOF. >>> >>> Huh. I thought I had git set up to reject me from making commits like= >>> that locally, but obviously not. >> >> There's another one in PATCH 13: >> >> /home/armbru/work/qemu/.git/rebase-apply/patch:156: new blank line at = EOF. >> >>> http://wiki.qemu.org/Contribute/SubmitAPatch should probably mention = the >>> magic one-time setup to use to turn this type of checking on... >> >> Feel free to add it :) >=20 > The wiki already mentions how: > * > [http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl= =2Ehtml > Automate a checkpatch run on commit] >=20 > but I had failed to 'chmod +x .git/hooks/pre-commit' to actually use it= =2E Actually, scripts/checkpatch.pl does NOT flag blank lines; so I want to also wire up git's default .git/hooks/pre-commit checker which can flag that type of damage (Stefan's blog and/or checkpatch.pl may need an updat= e). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XaVBwHvhpavXLa2oNbBmKJSxKF73o3ri1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVGzBjAAoJEKeha0olJ0NqnbMIAImWB26qvqhsPom4OoQzTLvI hHCuC1wysiQuyfW21kwDC7oceNYO18FvSXn1Hpycq6mkrwOxKYvCkDUhSAf4MZYY YCsYfdBISyUQQsbk89h543VEG3NX1plC3bO2KbyqXUDoY6AJULreovW3AxymEVaN x8LWIoLZlhKscO2WOuEPRu8+7NslhR0DxQFuzzSDnERaJ8Rz21+k6H7vhBV9AL2I yXZsw9oLeCCebX+98GKLegPGMjwkLOE0yrruQMkEWhAn0mhfUMCl89ylqkoV42mj 4pMLfcmN+weTA2cC5QPRt45NIqyJgMDTQ5rZxygwovKyjKoCljeO9Hfz9wogk6Q= =dIwO -----END PGP SIGNATURE----- --XaVBwHvhpavXLa2oNbBmKJSxKF73o3ri1--