From: Sudeep Holla <sudeep.holla@arm.com>
To: Michael Turquette <mike.turquette@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly
Date: Wed, 01 Apr 2015 11:01:14 +0100 [thread overview]
Message-ID: <551BC1EA.5030401@arm.com> (raw)
In-Reply-To: <551A67CD.50602@arm.com>
On 31/03/15 10:24, Sudeep Holla wrote:
> On 31/03/15 02:48, Michael Turquette wrote:
[...]
>> clk_set_rate returns an error (and always has), so it seems to me that
>> this patch is unnecessary. bL_cpufreq_set_rate checks for an error from
>> clk_set_rate and handles it.
>>
>
> No that's not correct, may be I was not clear earlier. Let me explain
> with the stack trace.
>
> bL_cpufreq_set_target(returns 0 even when clock driver returned error)
> |
> V
> clk_set_rate(returns whatever it get from clk_core_set_rate_nolock)
> |
> V
> clk_core_set_rate_nolock(always return 0 after calling clk_change_rate)
> |
> V
> clk_change_rate(void function, so no return)
> |
> V
> clk->ops->set_rate(i.e. <clock_driver_set_rate>)
>
> Now for drivers/clk/clk.c IIUC, the return value from clk->ops->set_rate
> is not checked. Now if <clock_driver_set_rate> returns error when h/w
> fails to set the rate, I would like to know how the error returned by
> <clock_driver_set_rate> is returned and received by clk_set_rate.
> Correct me if I am missing anything in the above sequence.
>
Any input on this ? or am I taking non-sense here ?
Regards,
Sudeep
next prev parent reply other threads:[~2015-04-01 10:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 12:27 [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Sudeep Holla
2015-03-30 12:27 ` [PATCH 2/2] cpufreq: arm_big_little: remove unused cpu-cluster.<n> clock name Sudeep Holla
2015-03-30 13:31 ` Viresh Kumar
2015-03-30 13:39 ` Sudeep Holla
2015-03-30 13:27 ` [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly Viresh Kumar
2015-03-30 13:39 ` Sudeep Holla
2015-03-31 1:48 ` Michael Turquette
2015-03-31 9:24 ` Sudeep Holla
2015-04-01 10:01 ` Sudeep Holla [this message]
2015-04-01 21:48 ` Michael Turquette
2015-04-02 8:55 ` Sudeep Holla
2015-04-13 5:08 ` Michael Turquette
2015-04-13 10:21 ` Sudeep Holla
2015-04-13 10:25 ` Viresh Kumar
2015-04-13 15:14 ` Sudeep Holla
2015-04-27 9:51 Sudeep Holla
2015-04-27 10:26 ` Viresh Kumar
2015-05-15 0:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BC1EA.5030401@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=mike.turquette@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.