From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753368AbbDATqo (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Apr 2015 15:46:44 -0400
Received: from mail-wg0-f47.google.com ([74.125.82.47]:34781 "EHLO
	mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752910AbbDATql (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Apr 2015 15:46:41 -0400
Message-ID: <551C4B1C.6060804@linaro.org>
Date: Wed, 01 Apr 2015 22:46:36 +0300
From: Georgi Djakov <georgi.djakov@linaro.org>
MIME-Version: 1.0
To: Hai Li <hali@codeaurora.org>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] clk: qcom: Introduce parent_map tables
References: <1426869026-26006-1-git-send-email-georgi.djakov@linaro.org> <1426869026-26006-4-git-send-email-georgi.djakov@linaro.org> <loom.20150401T161124-231@post.gmane.org>
In-Reply-To: <loom.20150401T161124-231@post.gmane.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1.04.15 17:22, Hai Li wrote:
> Hi Djakov,
> 
> Georgi Djakov <georgi.djakov <at> linaro.org> writes:
> 
>>
>> In the current parent mapping code, we can get duplicate or 
> inconsistent
>> indexes, which leads to discrepancy between the number of elements in 
> the
>> array and the number of parents. Until now, this was solved with some
>> reordering but this is not always possible.
>>
>> This patch introduces index tables that are used to define the 
> relations
>> between the PLL source and the hardware mux configuration value.
>> To accomplish this, here we do the following:
> 
> 
> There are other functions using f->src as index directly to find the 
> parent clock, at least the followings in file clk-rcg2.c:
> clk_pixel_determine_rate()
> _freq_tbl_determine_rate()
> clk_pixel_set_rate()
> clk_edp_pixel_determine_rate()
> clk_byte_determine_rate()
> 
> Shall we convert the index using qcom_find_src_index() at all these 
> places?
> 

Hi,
Yes, thanks for reporting this. I am working on a fix and trying
to verify it on all the platforms.

BR,
Georgi