From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752773AbbDBQaK (ORCPT ); Thu, 2 Apr 2015 12:30:10 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33522 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbbDBQaI (ORCPT ); Thu, 2 Apr 2015 12:30:08 -0400 Message-ID: <551D6E8D.6040504@osg.samsung.com> Date: Thu, 02 Apr 2015 10:30:05 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steven Rostedt , Namhyung Kim CC: Masami Hiramatsu , LKML , =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= , Michael Ellerman , Dave Jones , Luis Henriques , Shuah Khan Subject: Re: [PATCH v2.1] ftracetest: Do not use usleep directly References: <1427948663-25048-1-git-send-email-namhyung@kernel.org> <1427949253-26883-1-git-send-email-namhyung@kernel.org> <551CDA6C.50106@hitachi.com> <20150402093827.617192f0@gandalf.local.home> <551D5019.9010806@osg.samsung.com> <20150402110846.4e6a756c@gandalf.local.home> In-Reply-To: <20150402110846.4e6a756c@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/2015 09:08 AM, Steven Rostedt wrote: > On Thu, 02 Apr 2015 08:20:09 -0600 > Shuah Khan wrote: > > >>>>> Reported-by: Michael Ellerman >>>>> Reported-by: Dave Jones >>>>> Reported-by: Luis Henriques >>>>> Based-on-patch-by: Pádraig Brady >> >> Is this standard? checkpatch complained as non-standard. I am >> seeing some patches posted with Based-on-patch-by > > I ignore checkpatch for things like this. It doesn't have a foggiest > clue to what is standard. The only standard we truly have that counts > is "Signed-off-by", as that's partially a legal thing. Everything else > is info only. > > This patch was based on a idea by Pádraig Brady and Namhyung is giving > him credit. > > Hmm, since I do not believe that Pádraig sent a patch, but only > suggested the idea, the more "standard" tag, and actually more > appropriate tag would be: > > Suggested-by: Pádraig Brady > > Also, we probably should add: > > Link: http://lkml.kernel.org/r/1427329943-16896-1-git-send-email-namhyung@kernel.org > > Which has more of a history for this patch. I added the following to the commit log: For more information on the history of this patch, please refer to: http://lkml.kernel.org/r/1427329943-16896-1-git-send-email-namhyung@kernel.org > >> >> Anyway, I have this patch tagged for 4.1-rc2 > > Why rc2? I usually let the patches stay in next for a few days before I send pull request. It is getting close to that, so decided on rc2 as a better choice. We are at rc-6 at the moment, maybe there is enough time for this to get into rc-1 This patch has been in the works for a while now. Might as well get it in. Bummer. Now this patch conflicts with the following commits: ftracetest: Convert exit -1 to exit $FAIL ftracetest: Add basic event tracing test cases Applying: ftracetest: Do not use usleep directly error: patch failed: tools/testing/selftests/ftrace/test.d/event/event-enable.tc:12 error: tools/testing/selftests/ftrace/test.d/event/event-enable.tc: patch does not apply error: patch failed: tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc:12 error: tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc: patch does not apply error: patch failed: tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc:12 error: tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc: patch does not apply I could attempt to fix the conflicts, however prefer if you can rebase it on linux-kselftest next. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978