From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752561AbbDDAUx (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Apr 2015 20:20:53 -0400
Received: from mail-qc0-f182.google.com ([209.85.216.182]:36447 "EHLO
	mail-qc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751897AbbDDAUu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Apr 2015 20:20:50 -0400
Message-ID: <551F2E59.5080503@hurleysoftware.com>
Date: Fri, 03 Apr 2015 20:20:41 -0400
From: Peter Hurley <peter@hurleysoftware.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jiri Slaby <jslaby@suse.cz>,
        Mikael Starvik <starvik@axis.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-cris-kernel@axis.com,
        linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/3] tty: eliminate 64 byte stack buffers passed to tty_name
References: <1427810160-15779-1-git-send-email-linux@rasmusvillemoes.dk>
In-Reply-To: <1427810160-15779-1-git-send-email-linux@rasmusvillemoes.dk>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/31/2015 09:55 AM, Rasmus Villemoes wrote:
> All users of tty_name pass the return value directly to a printf
> function, so we might as well use tty->name directly instead of
> copying it to a user-supplied (stack) buffer.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>