From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 11/19] xen: arm: Annotate handlers for PCTR_EL2.Tx Date: Mon, 6 Apr 2015 13:18:43 +0200 Message-ID: <55226B93.6030906@citrix.com> References: <1427796446.2115.34.camel@citrix.com> <1427796462-24376-11-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427796462-24376-11-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, Subject: s/PCTR/CPTR/ On 31/03/2015 12:07, Ian Campbell wrote: > Signed-off-by: Ian Campbell > --- > xen/arch/arm/traps.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index 9cdbda8..ba120e5 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -1704,6 +1704,11 @@ static void do_cp15_32(struct cpu_user_regs *regs, > * ARMv7 (DDI 0406C.b): B1.14.3 > * ARMv8 (DDI 0487A.d): D1-1501 Table D1-43 > * > + * CPTR_EL2.T{0..9,12..13} > + * > + * ARMv7 (DDI 0406C.b): B1.14.12 > + * ARMv8 (DDI 0487A.d): N/A I would also update the comment on top of WRITE_SYSREG(..., CPTR_EL2) to make clear that CP0..CP9 & CP12..CP13 are only traps for ARMv7. Regards, -- Julien Grall