From: Wilco Baan Hofman <wilco@baanhofman.nl>
To: Eric Dumazet <eric.dumazet@gmail.com>, Tom Herbert <tom@herbertland.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pablo@netfilter.org, hannes@stressinduktion.org,
"Jiří Pírko" <jiri@resnulli.us>
Subject: Re: [PATCH 0/4] Prevent UDP tunnels from operating on garbage socket
Date: Tue, 07 Apr 2015 10:20:58 +0200 [thread overview]
Message-ID: <5523936A.9010609@baanhofman.nl> (raw)
In-Reply-To: <1428383028.25985.209.camel@edumazet-glaptop2.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
On 07/04/15 07:03, Eric Dumazet wrote:
> On Mon, 2015-04-06 at 21:45 -0700, Tom Herbert wrote:
>> On Mon, Apr 6, 2015 at 8:51 PM, David Miller <davem@davemloft.net> wrote:
>>> I don't see what is convoluted about using the correct socket for
>>> sending L3 protocol frames. That's in fact how it's _supposed_ to
>>> work. And consistently having a proper matching socket available
>>> makes it so that, long-term, we'll never have to deal with this issue
>>> ever again.
>> I guess this is where I'm confused. We can send just about anything
>> over GRE also, but have never needed a transmit socket for that. Is
>> UDP encapsulation so different, or is GRE equally broken also? Also,
>> will we need to add the socket to FOU and GUE then?
> GRE encap is very low level (not L3), and no socket simply sends GRE
> packets as is.
FWIW, GRE encap is also broken for IPv6, it's layer 2, but only 8 bytes
can be used of the IPv6 address, because it uses sll_addr.
-- Wilco
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2015-04-07 8:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 2:18 [PATCH 0/4] Prevent UDP tunnels from operating on garbage socket David Miller
2015-04-06 13:59 ` Tom Herbert
2015-04-06 16:41 ` David Miller
2015-04-06 17:17 ` David Miller
[not found] ` <CALx6S34CvOZN3dZjXr6_1afCbUDu2718cCGPk2Sm1Nkq8wCGKA@mail.gmail.com>
2015-04-06 19:38 ` David Miller
2015-04-07 2:43 ` Tom Herbert
2015-04-07 3:51 ` David Miller
2015-04-07 4:45 ` Tom Herbert
2015-04-07 5:03 ` Eric Dumazet
2015-04-07 8:20 ` Wilco Baan Hofman [this message]
2015-04-07 5:29 ` David Miller
2015-04-07 11:27 ` Hannes Frederic Sowa
2015-04-08 20:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5523936A.9010609@baanhofman.nl \
--to=wilco@baanhofman.nl \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.