From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Hannes Reinecke <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2] Split SCSI header files
Date: Tue, 7 Apr 2015 11:11:21 +0200 [thread overview]
Message-ID: <55239F39.4050605@sandisk.com> (raw)
In-Reply-To: <20150406150842.GA23569@lst.de>
On 04/06/15 17:08, Christoph Hellwig wrote:
> On Sun, Apr 05, 2015 at 08:12:16PM +0200, Bart Van Assche wrote:
>> Move the
>> functions that are used by both subsystems into <scsi/scsi_lib.h>.
>> Rename drivers/scsi/scsi_lib.c into scsi_ini_lib.c. This change
>> will allow to modify the SCSI target code such that the initiator
>> SCSI header files are no longer included. Note: the SCSI target
>> driver patch is available for review at
>
> I don't really like renaming the file that has most of the initiator side
> SCSI code that way. If we really have to rename it in some way I'd suggest
> just merging it into scsi.c as we call forth and back between the two all
> the time.
>
> Maybe we can use scsi_common.c/h/.ko to avoid these moves, although I'd
> prefer to just duplicate this tiny amount of code.
Hello Christoph,
Sorry but duplicating code is not really something that makes me
enthusiast ... But I will address all your other comments, including
using the names scsi_common.c/.h.
Bart.
prev parent reply other threads:[~2015-04-07 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 18:12 [PATCH v2] Split SCSI header files Bart Van Assche
2015-04-06 15:08 ` Christoph Hellwig
2015-04-07 9:11 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55239F39.4050605@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=JBottomley@odin.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.