From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: [PATCH v6 10/15] serial: stm32-usart: Add STM32 USART Driver Date: Tue, 07 Apr 2015 18:51:56 +0200 Message-ID: <55240B2C.3020102@suse.de> References: <1428424234-28572-1-git-send-email-mcoquelin.stm32@gmail.com> <1428424234-28572-11-git-send-email-mcoquelin.stm32@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1428424234-28572-11-git-send-email-mcoquelin.stm32@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Coquelin , u.kleine-koenig@pengutronix.de, geert@linux-m68k.org, Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl, peter@hurleysoftware.com, andy.shevchenko@gmail.com, cw00.choi@samsung.com, Russell King , Daniel Lezcano , joe@perches.com Cc: Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-arch@vger.kerne List-Id: linux-gpio@vger.kernel.org Am 07.04.2015 um 18:30 schrieb Maxime Coquelin: > This drivers adds support to the STM32 USART controller, which is a > standard serial driver. >=20 > Tested-by: Chanwoo Choi > Reviewed-by: Peter Hurley > Signed-off-by: Maxime Coquelin > --- > drivers/tty/serial/Kconfig | 17 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/stm32-usart.c | 735 +++++++++++++++++++++++++++++= ++++++++++ > include/uapi/linux/serial_core.h | 3 + > 4 files changed, 756 insertions(+) > create mode 100644 drivers/tty/serial/stm32-usart.c [...] > diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/st= m32-usart.c > new file mode 100644 > index 0000000..4adc430 > --- /dev/null > +++ b/drivers/tty/serial/stm32-usart.c [...] > +#define DRIVER_NAME "stm32-usart" > +#define STM32_SERIAL_NAME "ttyS" I'm surprised no one has complained about ttyS yet. Doesn't that need t= o be unique, such as ttySTM (efm32 uses ttyefm), to avoid clashes between serial drivers? ttyS was exclusive to the 8250 driver, I thought. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbbDGQwK (ORCPT ); Tue, 7 Apr 2015 12:52:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59125 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbbDGQwG (ORCPT ); Tue, 7 Apr 2015 12:52:06 -0400 Message-ID: <55240B2C.3020102@suse.de> Date: Tue, 07 Apr 2015 18:51:56 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Maxime Coquelin , u.kleine-koenig@pengutronix.de, geert@linux-m68k.org, Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl, peter@hurleysoftware.com, andy.shevchenko@gmail.com, cw00.choi@samsung.com, Russell King , Daniel Lezcano , joe@perches.com CC: Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v6 10/15] serial: stm32-usart: Add STM32 USART Driver References: <1428424234-28572-1-git-send-email-mcoquelin.stm32@gmail.com> <1428424234-28572-11-git-send-email-mcoquelin.stm32@gmail.com> In-Reply-To: <1428424234-28572-11-git-send-email-mcoquelin.stm32@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 07.04.2015 um 18:30 schrieb Maxime Coquelin: > This drivers adds support to the STM32 USART controller, which is a > standard serial driver. > > Tested-by: Chanwoo Choi > Reviewed-by: Peter Hurley > Signed-off-by: Maxime Coquelin > --- > drivers/tty/serial/Kconfig | 17 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/stm32-usart.c | 735 +++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/serial_core.h | 3 + > 4 files changed, 756 insertions(+) > create mode 100644 drivers/tty/serial/stm32-usart.c [...] > diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c > new file mode 100644 > index 0000000..4adc430 > --- /dev/null > +++ b/drivers/tty/serial/stm32-usart.c [...] > +#define DRIVER_NAME "stm32-usart" > +#define STM32_SERIAL_NAME "ttyS" I'm surprised no one has complained about ttyS yet. Doesn't that need to be unique, such as ttySTM (efm32 uses ttyefm), to avoid clashes between serial drivers? ttyS was exclusive to the 8250 driver, I thought. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?ISO-8859-15?Q?Andreas_F=E4rber?=) Date: Tue, 07 Apr 2015 18:51:56 +0200 Subject: [PATCH v6 10/15] serial: stm32-usart: Add STM32 USART Driver In-Reply-To: <1428424234-28572-11-git-send-email-mcoquelin.stm32@gmail.com> References: <1428424234-28572-1-git-send-email-mcoquelin.stm32@gmail.com> <1428424234-28572-11-git-send-email-mcoquelin.stm32@gmail.com> Message-ID: <55240B2C.3020102@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 07.04.2015 um 18:30 schrieb Maxime Coquelin: > This drivers adds support to the STM32 USART controller, which is a > standard serial driver. > > Tested-by: Chanwoo Choi > Reviewed-by: Peter Hurley > Signed-off-by: Maxime Coquelin > --- > drivers/tty/serial/Kconfig | 17 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/stm32-usart.c | 735 +++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/serial_core.h | 3 + > 4 files changed, 756 insertions(+) > create mode 100644 drivers/tty/serial/stm32-usart.c [...] > diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c > new file mode 100644 > index 0000000..4adc430 > --- /dev/null > +++ b/drivers/tty/serial/stm32-usart.c [...] > +#define DRIVER_NAME "stm32-usart" > +#define STM32_SERIAL_NAME "ttyS" I'm surprised no one has complained about ttyS yet. Doesn't that need to be unique, such as ttySTM (efm32 uses ttyefm), to avoid clashes between serial drivers? ttyS was exclusive to the 8250 driver, I thought. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg)