All of lore.kernel.org
 help / color / mirror / Atom feed
From: Skamra Mariusz <mariusz.skamra@tieto.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCHv2 04/27] android/hog: Remove tracking gatt operations
Date: Wed, 08 Apr 2015 10:47:28 +0200	[thread overview]
Message-ID: <5524EB20.8090807@tieto.com> (raw)
In-Reply-To: <CABBYNZK0gc4A6UaZHRZq5OJo1f2Vadd8QkCyOXWQ1LcAWFWj1A@mail.gmail.com>

Hi Luiz

On 2015-04-07 09:50, Luiz Augusto von Dentz wrote:
> Hi Mariusz,
>
> On Fri, Apr 3, 2015 at 4:43 PM, Mariusz Skamra <mariusz.skamra@tieto.com> wrote:
>> Since the use of bt_gatt_client there is no need to queue pending gatt
>> operations. bt_gatt_client already keeps track on that, so that
>> on bt_gatt_client_unref the queue of pending requests is destroyed.
>
> This assumption that unref will properly cancel the pending request is
> not correct, it will only do what you are saying if it is the last
> reference so we still need to track the requests and properly cancel
> them since we have no idea how many references of bt_gatt_client
> exists.

Thanks for that. I will remove this patch from hog as well as other 
profiles (scpp, dis, bas). I already discussed that with Szymon, and my 
intention was to delete all the requests after the last gatt_client 
dereference (just like you wrote). I assumed that if we want to 
disconnect/remove device, all the pending requests, no matter of which 
gatt based service will be removed.


  reply	other threads:[~2015-04-08  8:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 13:43 [PATCHv2 00/27] HoG: Replace gattrib with gatt_client Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 01/27] android/hidhost: Create bt_gatt_client Mariusz Skamra
2015-04-03 16:33   ` Michael Janssen
2015-04-03 13:43 ` [PATCHv2 02/27] android/hog: Introduce bt_gatt_client Mariusz Skamra
2015-04-07  7:44   ` Luiz Augusto von Dentz
2015-04-03 13:43 ` [PATCHv2 03/27] shared/gatt-client: Expose gatt_db Mariusz Skamra
2015-04-07  8:01   ` Luiz Augusto von Dentz
2015-04-03 13:43 ` [PATCHv2 04/27] android/hog: Remove tracking gatt operations Mariusz Skamra
2015-04-07  7:50   ` Luiz Augusto von Dentz
2015-04-08  8:47     ` Skamra Mariusz [this message]
2015-04-08 10:11       ` Luiz Augusto von Dentz
2015-04-03 13:43 ` [PATCHv2 05/27] android/hog: Use bt_gatt_client to read characteristic value Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 06/27] android/hog: Use bt_gatt_client to register for notifications Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 07/27] android/hog: Use bt_gatt_client to write without response Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 08/27] android/hog: Replace gatt_write_char with bt_gatt_client_write_value Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 09/27] android/hog: Use gatt_db to search for services and characteristics in db Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 10/27] android/hog: Add helper to create uhid device Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 11/27] lib/uuid: Add define for HoG UUID Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 12/27] android/hog: Replace list of reports with a queue of reports Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 13/27] android/hog: Replace GSList of hog instances with queue of instances Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 14/27] android/dis: Remove tracking pending gatt operations Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 15/27] android/dis: Introduce bt_gatt_client Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 16/27] android/scpp: Remove tracking pending gatt operations Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 17/27] android/scpp: Introduce bt_gatt_client Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 18/27] android/scpp: Merge refresh_discovered_cb with iwin_discovered_cb Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 19/27] android/bas: Remove tracking pending gatt operations Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 20/27] android/bas: Start using bt_gatt_client Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 21/27] android/hog: Strip btio dependencies Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 22/27] android/hog: Enable Input Report notifications only if uhid is created Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 23/27] android/bas: Enable Battery Level notifications after reconnection Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 24/27] android/hog: Clean the code from attrib dependencies Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 25/27] android/hog: Remove glib dependencies Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 26/27] android/hog: Remove redundant code Mariusz Skamra
2015-04-03 13:43 ` [PATCHv2 27/27] android/hog: Replace definitions of characteristic uuids with bt_uuids Mariusz Skamra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5524EB20.8090807@tieto.com \
    --to=mariusz.skamra@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.