From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH v2 3/3] drm/amdgpu: fix lock cleanup during buffer creation Date: Thu, 16 Feb 2017 10:00:54 +0900 Message-ID: <5526014c-45ee-55f6-1380-0915c8b52e10@daenzer.net> References: <20170215191056.17718-1-nhaehnle@gmail.com> <20170215191056.17718-3-nhaehnle@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170215191056.17718-3-nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Nicolai_H=c3=a4hnle?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?UTF-8?Q?Nicolai_H=c3=a4hnle?= List-Id: dri-devel@lists.freedesktop.org T24gMTYvMDIvMTcgMDQ6MTAgQU0sIE5pY29sYWkgSMOkaG5sZSB3cm90ZToKPiBGcm9tOiBOaWNv bGFpIEjDpGhubGUgPG5pY29sYWkuaGFlaG5sZUBhbWQuY29tPgo+IAo+IE9wZW4tY29kZSB0aGUg aW5pdGlhbCB0dG1fYm9fdmFsaWRhdGUgY2FsbCwgc28gdGhhdCB3ZSBjYW4gcHJvcGVybHkKPiB1 bmxvY2sgdGhlIHJlc2VydmF0aW9uIGxvY2sgd2hlbiBpdCBmYWlscy4gQWxzbywgcHJvcGVybHkg ZGVzdHJ1Y3QKPiB0aGUgcmVzZXJ2YXRpb24gb2JqZWN0IHdoZW4gdGhlIGZpcnN0IHBhcnQgb2Yg VFRNIEJPIGluaXRpYWxpemF0aW9uCj4gZmFpbHMuCj4gCj4gQWN0dWFsIGRlYWRsb2NrcyBjYXVz ZWQgYnkgdGhlIG1pc3NpbmcgdW5sb2NrIHNob3VsZCBoYXZlIGJlZW4gZml4ZWQKPiBieSAiZHJt L3R0bTogbmV2ZXIgYWRkIEJPIHRoYXQgZmFpbGVkIHRvIHZhbGlkYXRlIHRvIHRoZSBMUlUgbGlz dCIsCj4gc3VwZXJzZWRpbmcgdGhlIGZsYXdlZCBmaXggaW4gY29tbWl0IDM4ZmM0ODU2YWQ5OCAo ImRybS9hbWRncHU6IGZpeAo+IGEgcG90ZW50aWFsIGRlYWRsb2NrIGluIGFtZGdwdV9ib19jcmVh dGVfcmVzdHJpY3RlZCgpIikuCj4gCj4gVGhpcyBjaGFuZ2UgZml4ZXMgcmVtYWluaW5nIHJlY3Vy c2l2ZSBsb2NraW5nIGVycm9ycyB0aGF0IGNhbiBiZSBzZWVuCj4gd2l0aCBsb2NrIGRlYnVnZ2lu ZyBlbmFibGVkLCBhbmQgYXZvaWRzIHRoZSBlcnJvciBvZiBmcmVlaW5nIGEgbG9ja2VkCj4gbXV0 ZXguCj4gCj4gdjI6IHVzZSB0dG1fYm9fdW5yZWYgZm9yIGVycm9yIGhhbmRsaW5nLCBhbmQgcmVi YXNlIG9uIGxhdGVzdCBjaGFuZ2VzCj4gCj4gRml4ZXM6IDEyYTg1MjIxOTU4MyAoImRybS9hbWRn cHU6IGltcHJvdmUgQU1ER1BVX0dFTV9DUkVBVEVfVlJBTV9DTEVBUkVEIGhhbmRsaW5nICh2Miki KQo+IFNpZ25lZC1vZmYtYnk6IE5pY29sYWkgSMOkaG5sZSA8bmljb2xhaS5oYWVobmxlQGFtZC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuYyB8 IDI4ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIyIGlu c2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9vYmplY3QuYwo+IGluZGV4IGMyZTU3ZjcuLjE1OTQ0ZWEgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jCj4gQEAgLTQwNCwxNSArNDA0 LDMxIEBAIGludCBhbWRncHVfYm9fY3JlYXRlX3Jlc3RyaWN0ZWQoc3RydWN0IGFtZGdwdV9kZXZp Y2UgKmFkZXYsCj4gIAl9Cj4gIAo+ICAJaW5pdGlhbF9ieXRlc19tb3ZlZCA9IGF0b21pYzY0X3Jl YWQoJmFkZXYtPm51bV9ieXRlc19tb3ZlZCk7Cj4gLQlyID0gdHRtX2JvX2luaXQoJmFkZXYtPm1t YW4uYmRldiwgJmJvLT50Ym8sIHNpemUsIHR5cGUsCj4gLQkJCSZiby0+cGxhY2VtZW50LCBwYWdl X2FsaWduLCAha2VybmVsLCBOVUxMLAo+IC0JCQlhY2Nfc2l6ZSwgc2csIHJlc3YgPyByZXN2IDog JmJvLT50Ym8udHRtX3Jlc3YsCj4gLQkJCSZhbWRncHVfdHRtX2JvX2Rlc3Ryb3kpOwo+ICsJciA9 IHR0bV9ib19pbml0X3RvcCgmYWRldi0+bW1hbi5iZGV2LCAmYm8tPnRibywgc2l6ZSwgdHlwZSwK PiArCQkJICAgIHBhZ2VfYWxpZ24sIE5VTEwsCj4gKwkJCSAgICBhY2Nfc2l6ZSwgc2csIHJlc3Yg PyByZXN2IDogJmJvLT50Ym8udHRtX3Jlc3YsCj4gKwkJCSAgICAmYW1kZ3B1X3R0bV9ib19kZXN0 cm95KTsKPiArCj4gKwlpZiAobGlrZWx5KHIgPT0gMCkpCj4gKwkJciA9IHR0bV9ib192YWxpZGF0 ZSgmYm8tPnRibywgJmJvLT5wbGFjZW1lbnQsICFrZXJuZWwsIGZhbHNlKTsKPiArCj4gKwlpZiAo dW5saWtlbHkociAhPSAwKSkgewo+ICsJCXN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqdGJvID0g JmJvLT50Ym87Cj4gKwo+ICsJCWlmICghcmVzdikKPiArCQkJd3dfbXV0ZXhfdW5sb2NrKCZiby0+ dGJvLnR0bV9yZXN2LmxvY2spOwo+ICsJCXR0bV9ib191bnJlZigmdGJvKTsKPiArCQlyZXR1cm4g cjsKPiArCX0KCkkgdGhpbmsgdGhpcyB3b3VsZCBiZSBjbGVhcmVyIGFzCgoJaWYgKHVubGlrZWx5 KHIgIT0gMCkpIHsKCQlzdHJ1Y3QgdHRtX2J1ZmZlcl9vYmplY3QgKnRibyA9ICZiby0+dGJvOwoK CQlpZiAoIXJlc3YpCgkJCXd3X211dGV4X3VubG9jaygmYm8tPnRiby50dG1fcmVzdi5sb2NrKTsK CQl0dG1fYm9fdW5yZWYoJnRibyk7CgkJcmV0dXJuIHI7Cgl9CgoJciA9IHR0bV9ib192YWxpZGF0 ZSgmYm8tPnRibywgJmJvLT5wbGFjZW1lbnQsICFrZXJuZWwsIGZhbHNlKTsKCVsuLi5dCgoKPiAg CWFtZGdwdV9jc19yZXBvcnRfbW92ZWRfYnl0ZXMoYWRldiwKPiAgCQlhdG9taWM2NF9yZWFkKCZh ZGV2LT5udW1fYnl0ZXNfbW92ZWQpIC0gaW5pdGlhbF9ieXRlc19tb3ZlZCk7Cj4gIAo+IC0JaWYg KHVubGlrZWx5KHIgIT0gMCkpCj4gLQkJcmV0dXJuIHI7Cj4gKwlpZiAoIShiby0+dGJvLm1lbS5w bGFjZW1lbnQgJiBUVE1fUExfRkxBR19OT19FVklDVCkpIHsKPiArCQlzcGluX2xvY2soJmJvLT50 Ym8uZ2xvYi0+bHJ1X2xvY2spOwo+ICsJCXR0bV9ib19hZGRfdG9fbHJ1KCZiby0+dGJvKTsKPiAr CQlzcGluX3VubG9jaygmYm8tPnRiby5nbG9iLT5scnVfbG9jayk7Cj4gKwl9CgpJdCdzIGEgYml0 IHVnbHkgdG8gb3Blbi1jb2RlIHRoaXMgbG9naWMgaW4gZHJpdmVyIGNvZGUuIE1heWJlIGFkZAph bm90aGVyIFRUTSBoZWxwZXIgd2hpY2ggY2FsbHMgdHRtX2JvX3ZhbGlkYXRlIGFuZCB0dG1fYm9f YWRkX3RvX2xydT8KCgotLSAKRWFydGhsaW5nIE1pY2hlbCBEw6RuemVyICAgICAgICAgICAgICAg fCAgICAgICAgICAgICAgIGh0dHA6Ly93d3cuYW1kLmNvbQpMaWJyZSBzb2Z0d2FyZSBlbnRodXNp YXN0ICAgICAgICAgICAgIHwgICAgICAgICAgICAgTWVzYSBhbmQgWCBkZXZlbG9wZXIKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==