All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display
Date: Thu, 09 Apr 2015 13:38:10 +0000	[thread overview]
Message-ID: <552680C2.6020508@roeck-us.net> (raw)
In-Reply-To: <1428184513-22380-2-git-send-email-linux@roeck-us.net>

On 04/09/2015 04:31 AM, Jean Delvare wrote:
> Hi Guenter,
>
> On Sat,  4 Apr 2015 14:54:52 -0700, Guenter Roeck wrote:
>> Commit a6ebb8b09421 ("hwmon: (it87) Introduce feature flag to reflect internal
>> in7 sensor") actually caused in7 to never be recognized as internal.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>   drivers/hwmon/it87.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
>> index 4763d1157a5e..32180aaa4ac6 100644
>> --- a/drivers/hwmon/it87.c
>> +++ b/drivers/hwmon/it87.c
>> @@ -1910,7 +1910,7 @@ static int __init it87_find(unsigned short *address,
>>   		sio_data->internal |= (1 << 1);
>>
>>   	/* in8 (Vbat) is always internal */
>> -	sio_data->internal = (1 << 2);
>> +	sio_data->internal |= (1 << 2);
>>
>>   	/* Only the IT8603E has in9 */
>>   	if (sio_data->type != it8603)
>
> Meanwhile you merged that fix in patch "hwmon: (it87) Introduce feature
> flag to reflect internal in7 sensor" so this patch is no longer
> relevant, right?
>
Yes.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2015-04-09 13:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 21:54 [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display Guenter Roeck
2015-04-09 11:31 ` Jean Delvare
2015-04-09 13:38 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552680C2.6020508@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.