All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Bird <tim.bird@sonymobile.com>
To: Iulia Manda <iulia.manda21@gmail.com>,
	"josh@joshtriplett.org" <josh@joshtriplett.org>
Cc: "linux-embedded@vger.kernel.org" <linux-embedded@vger.kernel.org>,
	"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
	"dvhart@linux.intel.com" <dvhart@linux.intel.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mihai.caraman@freescale.com" <mihai.caraman@freescale.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] kernel: Add a new config option to remove command line parsing
Date: Thu, 9 Apr 2015 07:44:36 -0700	[thread overview]
Message-ID: <55269054.6030703@sonymobile.com> (raw)
In-Reply-To: <1427898893-8257-1-git-send-email-iulia.manda21@gmail.com>



On 04/01/2015 07:34 AM, Iulia Manda wrote:
> This patch introduces CONFIG_CMDLINE_PARSE option which conditionally compiles
> the support for parsing kernel command line arguments. The corresponding
> functions that actually do the parsing will be compiled out. 
> 
> This is used when no parameters will be specified neither at compile time nor at
> boot time.
> 
> Bloat-o-meter output (compared to the preivous version in which builtin cmdline
> was also set to 'Y'):
> 
> add/remove: 0/8 grow/shrink: 0/6 up/down: 0/-3669 (-3669)

I think this is great stuff.  (Of course, having research something like this
previously, I'm a bit biased.)

It's very nice to have the Bloat-o-meter output for these kernel size shrinking
patches.

The patch itself looks very straightforward, and I don't see any problems
in a visual inspection.

You can add a Reviewed-by: Tim Bird <tim.bird@sonymobile.com> to this patch.

I'd like to be able to point people to this on the mailing list.  In the future
can you make sure to CC: <linux-kernel@vger.kernel.org>, so there's a reference
on lkml.org I can point people to?

Thanks for this great work!
 -- Tim


  parent reply	other threads:[~2015-04-09 14:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 14:34 [PATCH 1/3] kernel: Add a new config option to remove command line parsing Iulia Manda
2015-04-01 14:34 ` [PATCH 2/3] linux: Add macros that define and declare a core_param variable Iulia Manda
2015-04-01 14:34 ` [PATCH 3/3] init: Set initcall_debug to a default value Iulia Manda
2015-04-09 14:44 ` Tim Bird [this message]
2015-05-18 11:50 [PATCH 1/3] kernel: Add a new config option to remove command line parsing Iulia Manda
2015-05-19  9:35 ` Paul Bolle
2015-05-20  0:54   ` josh
2015-05-20  6:29 ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55269054.6030703@sonymobile.com \
    --to=tim.bird@sonymobile.com \
    --cc=dvhart@linux.intel.com \
    --cc=iulia.manda21@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-embedded@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.caraman@freescale.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.