From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YgS8c-0000FR-2Y
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 02:09:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YgS8Y-0006a9-QB
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 02:09:57 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:60714)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YgS8Y-0006Yp-7y
	for qemu-devel@nongnu.org; Fri, 10 Apr 2015 02:09:54 -0400
Message-ID: <552767E8.2040105@huawei.com>
Date: Fri, 10 Apr 2015 14:04:24 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com>
	<1428055432-12120-13-git-send-email-zhaoshenglong@huawei.com>
	<87y4m1z49y.fsf@linaro.org>
	<CAFEAcA9OqtuV8y=gESYtP4J2+MPz_u8wnCm_JJ1oYoXUXshTDw@mail.gmail.com>
In-Reply-To: <CAFEAcA9OqtuV8y=gESYtP4J2+MPz_u8wnCm_JJ1oYoXUXshTDw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 12/20] hw/arm/virt-acpi-build: Add PCIe
 info and generate MCFG table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: hangaohuai@huawei.com, "Michael S. Tsirkin" <mst@redhat.com>, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, Mark Salter <msalter@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, "Huangpeng
	(Peter)" <peter.huangpeng@huawei.com>, Hanjun Guo <hanjun.guo@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 2015/4/10 0:00, Peter Maydell wrote:
> On 9 April 2015 at 16:54, Alex Bennée <alex.bennee@linaro.org> wrote:
>> >
>> > Shannon Zhao <zhaoshenglong@huawei.com> writes:
>> >
>>> >> From: Shannon Zhao <shannon.zhao@linaro.org>
>>> >> +build_mcfg(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info)
>>> >> +{
>>> >> +    AcpiTableMcfg *mcfg;
>>> >> +    acpi_pcie_info *info = guest_info->pcie_info;
>>> >> +    int len = sizeof(*mcfg) + 1 * sizeof(mcfg->allocation[0]);
>> >
>> > Explicit bracketing around the maths please.
> This doesn't seem to make much sense anyway:
> if the addition was intended to take precedence
> then we're adding 1 to a size-of-a-struct, which is
> a bit weird. And if the multiplication was intended
> to take precedence then it's doing a pointless multiply
> by one. Please can you check that this is actually
> calculating the right value?

The 1 means here only a single allocation for use.

-- 
Thanks,
Shannon